Closed
Bug 668956
Opened 13 years ago
Closed 13 years ago
Takes the address of a temporary
Categories
(Toolkit :: Places, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: espindola, Unassigned)
Details
Attachments
(1 file)
|
813 bytes,
patch
|
Details | Diff | Splinter Review |
clang found this:
/Users/espindola/mozilla-central/toolkit/components/places/nsNavHistoryResult.cpp:3163:23: error: taking the address of a temporary object of type 'NS_ConvertUTF16toUTF8'
[-Waddress-of-temporary]
&NS_ConvertUTF16toUTF8(aNewValue));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The attached patch fixes it.
Attachment #543581 -
Flags: review?(philipp)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 543581 [details] [diff] [review] fix This looks good to me (except for the one letter variable name). Marco should really be reviewing this, though.
Attachment #543581 -
Flags: review?(philipp) → review?(mak77)
|
||
Comment 2•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/3cb00dc5d94b
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WORKSFORME
|
|
||
Updated•13 years ago
|
Attachment #543581 -
Flags: review?(mak77)
You need to log in
before you can comment on or make changes to this bug.
Description
•