668956 - Takes the address of a temporary

Status: RESOLVED WORKSFORME

(Toolkit :: Places, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: fix

clang found this:

/Users/espindola/mozilla-central/toolkit/components/places/nsNavHistoryResult.cpp:3163:23: error: taking the address of a temporary object of type 'NS_ConvertUTF16toUTF8'
      [-Waddress-of-temporary]
                      &NS_ConvertUTF16toUTF8(aNewValue));
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The attached patch fixes it.

Comment 1

[Philipp von Weitershausen [:philikon]]

Comment on attachment 543581 [details] [diff] [review]
fix

This looks good to me (except for the one letter variable name). Marco should really be reviewing this, though.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/mozilla-central/rev/3cb00dc5d94b