Created attachment 543581 [details] [diff] [review] fix clang found this: /Users/espindola/mozilla-central/toolkit/components/places/nsNavHistoryResult.cpp:3163:23: error: taking the address of a temporary object of type 'NS_ConvertUTF16toUTF8' [-Waddress-of-temporary] &NS_ConvertUTF16toUTF8(aNewValue)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ The attached patch fixes it.
Attachment #543581 - Flags: review?(philipp)
Comment on attachment 543581 [details] [diff] [review] fix This looks good to me (except for the one letter variable name). Marco should really be reviewing this, though.
Attachment #543581 - Flags: review?(philipp) → review?(mak77)
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.