Takes the address of a temporary

RESOLVED WORKSFORME

Status

()

Toolkit
Places
RESOLVED WORKSFORME
7 years ago
7 years ago

People

(Reporter: espindola, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 543581 [details] [diff] [review]
fix

clang found this:

/Users/espindola/mozilla-central/toolkit/components/places/nsNavHistoryResult.cpp:3163:23: error: taking the address of a temporary object of type 'NS_ConvertUTF16toUTF8'
      [-Waddress-of-temporary]
                      &NS_ConvertUTF16toUTF8(aNewValue));
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The attached patch fixes it.
Attachment #543581 - Flags: review?(philipp)
Comment on attachment 543581 [details] [diff] [review]
fix

This looks good to me (except for the one letter variable name). Marco should really be reviewing this, though.
Attachment #543581 - Flags: review?(philipp) → review?(mak77)
http://hg.mozilla.org/mozilla-central/rev/3cb00dc5d94b
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WORKSFORME

Updated

7 years ago
Attachment #543581 - Flags: review?(mak77)
You need to log in before you can comment on or make changes to this bug.