668958 - #calendar-status-todaypane-button should use the aero icon

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Richard Marti (:Paenglab)]

As the summary says the #calendar-status-todaypane-button should use the aero icon

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Give the aero icon

Choose with lightning-aero.css the aero icon when under Vista/Win7

Comment 2

[Decathlon]

The date number on the icon appears misplaced 1 pixel to the left with the aero theme. It's not a problem of the new icon, it happens with the old one too.
This code in the same lightning-aero.css file of this patch fixes the position:

#calendar-status-todaypane-button > stack > .toolbarbutton-day-text {
   margin-left: 1px;
}

it could be added to the patch for this bug, or does the issue need a specific bug?

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Give the aero icon and position the date number

Patch with Decathlon's proposal.

Comment 4

[Decathlon]

Comment on attachment 543989 [details] [diff] [review]
Give the aero icon and position the date number

r+  ;-)


There are two icons that don't use the aero theme yet i.e. those in the "write" drop-down button in the main toolbar.

Comment 5

[Richard Marti (:Paenglab)]

(In reply to comment #4)
> There are two icons that don't use the aero theme yet i.e. those in the
> "write" drop-down button in the main toolbar.

I'll open a new bug.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: Give the aero icons

Because this patch isn't checked-in and the change is minimal I added the icons in the "write" drop-down button.

Comment 7

[Decathlon]

Comment on attachment 545064 [details] [diff] [review]
Give the aero icons

It works fine.
r+

Comment 8

[Jonathan Protzenko [:protz]]

http://hg.mozilla.org/comm-central/rev/408ad8acf001

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Thanks for taking care of the checkin! Could you also check in on comm-miramar, both on the default and COMM50_20110620_RELBRANCH branches (and set the target milestone to 1.0b5 then)? If you don't have time I'll take care within the next few days

Comment 10

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to comm-miramar <http://hg.mozilla.org/releases/comm-miramar/rev/3afe9bcae179> and <http://hg.mozilla.org/releases/comm-miramar/rev/45face4cd4d6>