Remove the padding around the Calendar list

RESOLVED FIXED in 1.0b7

Status

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

Trunk
1.0b7
x86
Windows 7

Details

Attachments

(8 attachments, 4 obsolete attachments)

Make the look of the Calendar list similar to the Folder list (treeitems are touching the window/splitter).
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #543587 - Flags: ui-review?(nisses.mail)
Attachment #543587 - Flags: review?(philipp)
Comment on attachment 543587 [details] [diff] [review]
Remove the padding/margin on both sides

I'm fine with this change if Philip is.
Attachment #543587 - Flags: ui-review?(nisses.mail) → ui-review+
Could you attach a screenshot on how this looks on other platforms? For mac it doesn't seem to change much, you'd have to change the padding in .task-tree-subpane (lightning.css, although it would probably be better to change classes) and possibly also #calendar-panel (also lightning.css)
I changed the margin/padding where I could do it. One point was #calendar-panel. But .task-tree-subpane has no definitions where I could change something.
Posted image Sidebar under Win7 β€”
On the left side before patch and on the right side after patch
Posted image Sidebar under Linux β€”
(In reply to comment #3)
> Could you attach a screenshot on how this looks on other platforms? For mac
> it doesn't seem to change much

I have no access to a Mac. I copied the changes from Win/Linux to Mac in the hope this also works here. Can you attach a screenshot on Mac?
Posted image Sidebar under mac β€”
This is what it looks like on mac. The culprit rule is:

http://mxr.mozilla.org/comm-central/source/calendar/lightning/themes/pinstripe/lightning.css#114

which controls the margin for both the filter list and the calendar list.
Attachment #547051 - Attachment description: Sidebar on mac → Sidebar under mac
Is this with the patch applied?
Do you mean the indention on the left and is this standard style for Mac programms? If not, this could be removed. Or should I do only a patch for Win/Linux?
With the patch applied. I think this rule can be removed, its not standard style. The folder pane has less padding left.
Patch with removing the .task-tree-subpane rule under Mac.

Taking ui-r+ from previous patch.
Attachment #543587 - Attachment is obsolete: true
Attachment #547190 - Flags: ui-review+
Attachment #547190 - Flags: review?(philipp)
Attachment #543587 - Flags: review?(philipp)
Attachment #547190 - Attachment is patch: true
Attachment #547190 - Attachment mime type: text/x-patch → text/plain
What about giving some indentation to the calendar list (and the tasks filter) related to the element that expands/collapses the list?
The same indentation is present in the folder list of Thunderbird.
I tried the indentation but failed  with the tree. I haven't found the correct selector. With padding-start on #calendar-list-tree-widget treechildren::-moz-tree-cell the checkbox and text are moving correct, but calendar color quadrate isn't moving and overlaps the checkbox.

If you can tell me the selector (DOMi can't inspect trees) for the quadrate I can update the patch. Else we should leave the patch as it is now.
Posted patch patch with indentation β€” β€” Splinter Review
Richard, you are right, it isn't so easy, at least for me.
I'm able to find only this solution (patch only for winstripe theme), but probably it isn't the best because it merely adds a margin to the checkbox image.
What's your opinion?
Thank you Decathlon for the tip. Padding removed, but given again on the left for the tree style indentation ;)

I removed the dotted bottom border for the titles, also to give more tree style
Attachment #547190 - Attachment is obsolete: true
Attachment #548006 - Flags: review?(philipp)
Attachment #547190 - Flags: review?(philipp)
Added gnomestripe support
Attachment #548006 - Attachment is obsolete: true
Attachment #553899 - Flags: review?(philipp)
Attachment #548006 - Flags: review?(philipp)
Attachment #553899 - Flags: review?(philipp) → review?(bv1578)
I've found another solution for the calendar list indentation.
It's based on the "tree-scrollable-columns" box's class from the treecols binding in the toolkit:
http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/widgets/tree.xml#935

Instead of adding the class "checkbox-treecol-class" and related padding, we could simply add the padding to that box in this way:

calendar-list-tree .tree-scrollable-columns {
  -moz-padding-start: 18px;
}
(in the calendar-widgets.css file).

It moves to the right the content of the box i.e. all the elements of the tree, so the effect is the same, but it seems more rational/functional.

Richard, what's your opinion? Which solution is preferable?
(In reply to Decathlon from comment #19)
> It moves to the right the content of the box i.e. all the elements of the
> tree, so the effect is the same, but it seems more rational/functional.
> 
> Richard, what's your opinion? Which solution is preferable?

As you wrote, it seems more rational/functional. And we have to touch one file fewer :)

This patch is using you suggestion.
Attachment #553899 - Attachment is obsolete: true
Attachment #561537 - Flags: review?(bv1578)
Attachment #553899 - Flags: review?(bv1578)
Comment on attachment 561537 [details] [diff] [review]
Remove the padding/margin on both sides v5

For Mac and Linux I can't test the patch, but I suppose it works like it should. The only difference in the code is the class task-tree-subpane  and the padding in the #task-tree-filtergroup for the Mac platform.

r+
Attachment #561537 - Flags: review?(bv1578) → review+
Pushed to comm-central

<http://hg.mozilla.org/comm-central/rev/c18e5085a08a>
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Backported to comm-beta

<http://hg.mozilla.org/releases/comm-beta/rev/513cc948c501>
Target Milestone: --- → 1.0b7
You need to log in before you can comment on or make changes to this bug.