Closed Bug 668969 Opened 10 years ago Closed 10 years ago

Empty mfenced elements should display fences

Categories

(Core :: MathML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: fs, Assigned: fs)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

> Perhaps we can just remove the if statement here?
> http://mxr.mozilla.org/mozilla-central/source/layout/mathml/
> nsMathMLmfencedFrame.cpp#354

Yes, I think I will work. We just have to verified that we won't use null Frame pointer or similar.
Assignee: nobody → elchi3
Status: NEW → ASSIGNED
Attachment #543603 - Flags: review?(karlt)
(In reply to comment #2)
> Created attachment 543603 [details] [diff] [review] [review]
> Fix: Removes the if condition

Did you test it? I think I read it too quickly this morning, and thought this if statement was to leave the function when the mfenced is empty.
Comment on attachment 543603 [details] [diff] [review]
Fix: Removes the if condition

Yes, I agree that the empty mfenced should not be handled specially here.

The centering logic happens to provide additional size so that the fences become visible.  This is still not quite exactly how they should be, but is definitely better.

The height of the fences should be considered in containerSize and I don't see
that happening.  This might be a regression from bug 414277, because, before then, characters were always stretched to at least their base size.

This patch is at least part of the solution and good enough for this bug.
Attachment #543603 - Flags: review?(karlt) → review+
Blocks: 553918
Filed bug 670334 to follow-up the height issue.
Merged:
http://hg.mozilla.org/mozilla-central/rev/c262b7cdfd2f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
Version: unspecified → Trunk
Is this tested with tests in bug 553918?
(In reply to comment #8)
> Is this tested with tests in bug 553918?

Yes, it is.
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.