Closed Bug 668972 Opened 13 years ago Closed 13 years ago

blocked-popups options popup leaks content windows

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 7
Tracking Status
firefox6 --- affected

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: memory-leak)

Attachments

(1 file)

Attached patch patchSplinter Review
The menuitems have references to the content window (menuitem.requestingWindow) and document (menuitem.requestingDocument) and stick around when the options popup closes, until you open it again, at which point there will be new menuitems with new content references.
Attachment #543590 - Flags: review?(gavin.sharp)
Attachment #543590 - Flags: review?(gavin.sharp) → review+
http://hg.mozilla.org/mozilla-central/rev/46697c40b104
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7
Attachment #543590 - Flags: approval-mozilla-aurora?
Attachment #543590 - Flags: approval-mozilla-aurora? → approval-mozilla-beta?
How can this be verified?
Thx.
Comment on attachment 543590 [details] [diff] [review]
patch

Sounds like at worst we leak one pop-up when this happens? If so, this doesn't seem like the kind of change we want to put into Beta.
Attachment #543590 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Can anyone please provide some STR / guidelines to verify this fix?

Thanks!
You need to log in before you can comment on or make changes to this bug.