Closed
Bug 668972
Opened 14 years ago
Closed 14 years ago
blocked-popups options popup leaks content windows
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 7
| Tracking | Status | |
|---|---|---|
| firefox6 | --- | affected |
People
(Reporter: dao, Assigned: dao)
References
Details
(Keywords: memory-leak)
Attachments
(1 file)
|
2.02 KB,
patch
|
Gavin
:
review+
asa
:
approval-mozilla-beta-
|
Details | Diff | Splinter Review |
The menuitems have references to the content window (menuitem.requestingWindow) and document (menuitem.requestingDocument) and stick around when the options popup closes, until you open it again, at which point there will be new menuitems with new content references.
Attachment #543590 -
Flags: review?(gavin.sharp)
|
||
Updated•14 years ago
|
Attachment #543590 -
Flags: review?(gavin.sharp) → review+
|
Assignee | |
Comment 1•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7
|
|
Assignee | |
Updated•14 years ago
|
Attachment #543590 -
Flags: approval-mozilla-aurora?
|
|
Assignee | |
Updated•14 years ago
|
status-firefox6:
--- → affected
|
|
Assignee | |
Updated•14 years ago
|
Attachment #543590 -
Flags: approval-mozilla-aurora? → approval-mozilla-beta?
|
||
Comment 3•14 years ago
|
||
Comment on attachment 543590 [details] [diff] [review]
patch
Sounds like at worst we leak one pop-up when this happens? If so, this doesn't seem like the kind of change we want to put into Beta.
Attachment #543590 -
Flags: approval-mozilla-beta? → approval-mozilla-beta-
|
||
Comment 4•13 years ago
|
||
Can anyone please provide some STR / guidelines to verify this fix?
Thanks!
You need to log in
before you can comment on or make changes to this bug.
Description
•