The default bug view has changed. See this FAQ.

blocked-popups options popup leaks content windows

RESOLVED FIXED in Firefox 7

Status

()

Firefox
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

({mlk})

Trunk
Firefox 7
Points:
---

Firefox Tracking Flags

(firefox6 affected)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 543590 [details] [diff] [review]
patch

The menuitems have references to the content window (menuitem.requestingWindow) and document (menuitem.requestingDocument) and stick around when the options popup closes, until you open it again, at which point there will be new menuitems with new content references.
Attachment #543590 - Flags: review?(gavin.sharp)
Attachment #543590 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 1

6 years ago
http://hg.mozilla.org/mozilla-central/rev/46697c40b104
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7
(Assignee)

Updated

6 years ago
Attachment #543590 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

6 years ago
status-firefox6: --- → affected
(Assignee)

Updated

6 years ago
Attachment #543590 - Flags: approval-mozilla-aurora? → approval-mozilla-beta?

Comment 2

6 years ago
How can this be verified?
Thx.

Comment 3

6 years ago
Comment on attachment 543590 [details] [diff] [review]
patch

Sounds like at worst we leak one pop-up when this happens? If so, this doesn't seem like the kind of change we want to put into Beta.
Attachment #543590 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Can anyone please provide some STR / guidelines to verify this fix?

Thanks!
You need to log in before you can comment on or make changes to this bug.