Closed Bug 669044 Opened 9 years ago Closed 9 years ago

TM: "Assertion failure: obj->getPrivate() == fp,"

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: gkw, Assigned: luke)

References

Details

(Keywords: assertion, regression, testcase, Whiteboard: [fixed-in-tracemonkey][inbound])

Attachments

(2 files)

Attached file stack
for each(let y in [0, 0]) {
    eval("\
        for each(e in[0,0,0,0,0,0,0,0]) {\
            x = undefined\
        }\
    ")
}


asserts js debug shell on TM changeset f59568ec0513 with -j at Assertion failure: obj->getPrivate() == fp,

autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   70604:bb9e5496b0ac
user:        Luke Wagner
date:        Fri May 13 08:56:26 2011 -0700
summary:     Bug 656462, part 4 - Simplify stack code, keep track of native calls, create new iterator over native/scripted callstack, make JS_SaveFrameChain fallible (r=waldo,mrbkap)
Still occurs on TM changeset d8e967b8afc8.
Summary: "Assertion failure: obj->getPrivate() == fp," → TM: "Assertion failure: obj->getPrivate() == fp,"
I'm not sure what possessed me to attempt to simplify this assertion (http://hg.mozilla.org/mozilla-central/rev/bb9e5496b0ac#l19.91), but its clearly invalid.  This patch puts it back and adds a test.
Assignee: general → luke
Status: NEW → ASSIGNED
Attachment #544085 - Flags: review?(dvander)
Comment on attachment 544085 [details] [diff] [review]
put the assert back to the way it was

Review of attachment 544085 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #544085 - Flags: review?(dvander) → review+
http://hg.mozilla.org/tracemonkey/rev/464f65a4cb87
Whiteboard: fixed-in-tracemonkey
This (along with most things committed on Friday afternoon) was backed out of mozilla-inbound in order to clear up orange.
http://hg.mozilla.org/integration/mozilla-inbound/rev/08af9ad317a1
Whiteboard: fixed-in-tracemonkey → [fixed-in-tracemonkey][inbound]
http://hg.mozilla.org/mozilla-central/rev/08af9ad317a1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
Automatically extracted testcase for this bug was committed:

https://hg.mozilla.org/mozilla-central/rev/efaf8960a929
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.