669044 - TM: "Assertion failure: obj->getPrivate() == fp,"

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: stack

for each(let y in [0, 0]) {
    eval("\
        for each(e in[0,0,0,0,0,0,0,0]) {\
            x = undefined\
        }\
    ")
}


asserts js debug shell on TM changeset f59568ec0513 with -j at Assertion failure: obj->getPrivate() == fp,

autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   70604:bb9e5496b0ac
user:        Luke Wagner
date:        Fri May 13 08:56:26 2011 -0700
summary:     Bug 656462, part 4 - Simplify stack code, keep track of native calls, create new iterator over native/scripted callstack, make JS_SaveFrameChain fallible (r=waldo,mrbkap)

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Still occurs on TM changeset d8e967b8afc8.

Comment 2

[Luke Wagner [:luke]]

Attachment: put the assert back to the way it was

I'm not sure what possessed me to attempt to simplify this assertion (http://hg.mozilla.org/mozilla-central/rev/bb9e5496b0ac#l19.91), but its clearly invalid.  This patch puts it back and adds a test.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 544085 [details] [diff] [review]
put the assert back to the way it was

Review of attachment 544085 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 4

[Luke Wagner [:luke]]

http://hg.mozilla.org/tracemonkey/rev/464f65a4cb87

Comment 5

[Joe Drew (not getting mail)]

This (along with most things committed on Friday afternoon) was backed out of mozilla-inbound in order to clear up orange.

Comment 6

[Luke Wagner [:luke]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/08af9ad317a1

Comment 7

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/08af9ad317a1

Comment 8

[Christian Holler (:decoder)]

Automatically extracted testcase for this bug was committed:

https://hg.mozilla.org/mozilla-central/rev/efaf8960a929