669049 - .response with .responseType='blob' doesn't work correctly for large remote file

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Masatoshi Kimura [:emk]]

See bug 661582 comment #19.

Comment 1

[Masatoshi Kimura [:emk]]

Unfortunately my build environment is broken at the moment. I'm not sure I can write a patch for this bug...

Comment 2

[Masatoshi Kimura [:emk]]

> I'm not sure I can write a patch for this bug...
until next aurora merge.

Comment 3

[Masatoshi Kimura [:emk]]

I think we should disable .responseType='blob' support on Firefox 6 unless this bug is fixed.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Forgo the cache optimization for correctness.

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 545283 [details] [diff] [review]
Forgo the cache optimization for correctness.

Review of attachment 545283 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 545283 [details] [diff] [review]
Forgo the cache optimization for correctness.

Drivers, this patch removes an optimization that still has some problems.  We should take this patch for Firefox 6 and 7, and fix this bug correctly for Firefox 8.

Comment 7

[LegNeato]

Kyle, can you land this today?

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/9e82442fe643
http://hg.mozilla.org/releases/mozilla-beta/rev/8d3fafa80d4b

Leaving the bug open because I still need to fix this on 8.

Comment 9

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 545283 [details] [diff] [review]
Forgo the cache optimization for correctness.

I forgot to fix this on trunk before the merge, so we'll need to check the bandaid into aurora again :-/

Comment 10

[Johnathan Nightingale [:johnath]]

Comment on attachment 545283 [details] [diff] [review]
Forgo the cache optimization for correctness.

Approved on the assumption that this is the same bandaid we have shipped in 6 and 7, and with the fervent hope that we get the for real fix in soon!

Comment 11

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Didn't my real fix land on trunk in time to fix this too?

Comment 12

[Masatoshi Kimura [:emk]]

Yeah, attachment 543659 [details] works on Aurora 8.0a2. The root cause has been fixed by bug 669433. So we don't have to apply the bandaid anymore.
But we should add attachment 543659 [details] as an automated test to prevent further regressions.

Comment 13

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/2bdd9c852f54

Comment 14

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to Jonas Sicking (:sicking) from comment #11)
> Didn't my real fix land on trunk in time to fix this too?

Oh, I thought there was more to do here :-/

Comment 15

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/7d122e5b3455

I backed this out of Aurora.

Comment 16

[Masatoshi Kimura [:emk]]

Attachment: automated test

Comment 17

[Masatoshi Kimura [:emk]]

Attachment: rebased to tip

Comment 18

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 562268 [details] [diff] [review]
rebased to tip

Review of attachment 562268 [details] [diff] [review]:
-----------------------------------------------------------------

I think the new tests in test_xhr_progressevents somewhat covers this case. Though it explicitly disables caching, so maybe it's best to take this one too.

Comment 19

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb91c8798858

Comment 20

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/fb91c8798858

Comment 21

[Ioana (away)]

Verified that the automated for this bug test has passed on Linux, Mac, Win 7 and Win XP:
Fx beta (8b1)
https://tbpl.mozilla.org/php/getParsedLog.php?id=6675073&full=1
https://tbpl.mozilla.org/php/getParsedLog.php?id=6663377&full=1
https://tbpl.mozilla.org/php/getParsedLog.php?id=6660944&full=1
https://tbpl.mozilla.org/php/getParsedLog.php?id=6675039&full=1

Fx aurora (9a2) 
https://tbpl.mozilla.org/php/getParsedLog.php?id=6673423&full=1
https://tbpl.mozilla.org/php/getParsedLog.php?id=6675104&full=1
https://tbpl.mozilla.org/php/getParsedLog.php?id=6674870&full=1
https://tbpl.mozilla.org/php/getParsedLog.php?id=6674891&full=1

Fx central (10a1)
https://tbpl.mozilla.org/php/getParsedLog.php?id=6680926&full=1
https://tbpl.mozilla.org/php/getParsedLog.php?id=6681523&full=1
https://tbpl.mozilla.org/php/getParsedLog.php?id=6681795&full=1
https://tbpl.mozilla.org/php/getParsedLog.php?id=6681778&full=1

Fx release
https://tbpl.mozilla.org/php/getParsedLog.php?id=6613063&full=1
https://tbpl.mozilla.org/php/getParsedLog.php?id=6614891&full=1
https://tbpl.mozilla.org/php/getParsedLog.php?id=6598770&full=1
https://tbpl.mozilla.org/php/getParsedLog.php?id=6598944&full=1