.response with .responseType='blob' doesn't work correctly for large remote file

VERIFIED FIXED in Firefox 6

Status

()

defect
VERIFIED FIXED
8 years ago
3 months ago

People

(Reporter: emk, Assigned: khuey)

Tracking

unspecified
mozilla9
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox5 unaffected, firefox6 fixed, firefox7 fixed, firefox8 fixed)

Details

(Whiteboard: [qa!], )

Attachments

(2 attachments, 1 obsolete attachment)

Reporter

Comment 1

8 years ago
Unfortunately my build environment is broken at the moment. I'm not sure I can write a patch for this bug...
Reporter

Comment 2

8 years ago
> I'm not sure I can write a patch for this bug...
until next aurora merge.
Reporter

Comment 3

8 years ago
I think we should disable .responseType='blob' support on Firefox 6 unless this bug is fixed.
Comment on attachment 545283 [details] [diff] [review]
Forgo the cache optimization for correctness.

Review of attachment 545283 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #545283 - Flags: review?(jonas) → review+
Comment on attachment 545283 [details] [diff] [review]
Forgo the cache optimization for correctness.

Drivers, this patch removes an optimization that still has some problems.  We should take this patch for Firefox 6 and 7, and fix this bug correctly for Firefox 8.
Attachment #545283 - Flags: approval-mozilla-beta?
Attachment #545283 - Flags: approval-mozilla-aurora?

Updated

8 years ago
Whiteboard: [temp workaround to avoid disabling .responseType='blob']

Updated

8 years ago
Attachment #545283 - Flags: approval-mozilla-beta?
Attachment #545283 - Flags: approval-mozilla-beta+
Attachment #545283 - Flags: approval-mozilla-aurora?
Attachment #545283 - Flags: approval-mozilla-aurora+

Comment 7

8 years ago
Kyle, can you land this today?
Comment on attachment 545283 [details] [diff] [review]
Forgo the cache optimization for correctness.

I forgot to fix this on trunk before the merge, so we'll need to check the bandaid into aurora again :-/
Attachment #545283 - Flags: approval-mozilla-aurora+ → approval-mozilla-aurora?
Comment on attachment 545283 [details] [diff] [review]
Forgo the cache optimization for correctness.

Approved on the assumption that this is the same bandaid we have shipped in 6 and 7, and with the fervent hope that we get the for real fix in soon!
Attachment #545283 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Didn't my real fix land on trunk in time to fix this too?
Reporter

Comment 12

8 years ago
Yeah, attachment 543659 [details] works on Aurora 8.0a2. The root cause has been fixed by bug 669433. So we don't have to apply the bandaid anymore.
But we should add attachment 543659 [details] as an automated test to prevent further regressions.
(In reply to Jonas Sicking (:sicking) from comment #11)
> Didn't my real fix land on trunk in time to fix this too?

Oh, I thought there was more to do here :-/
Reporter

Comment 16

8 years ago
Posted patch automated test (obsolete) — Splinter Review
Attachment #561902 - Flags: review?(jonas)
Reporter

Comment 17

8 years ago
Attachment #561902 - Attachment is obsolete: true
Attachment #562268 - Flags: review?(jonas)
Attachment #561902 - Flags: review?(jonas)
Comment on attachment 562268 [details] [diff] [review]
rebased to tip

Review of attachment 562268 [details] [diff] [review]:
-----------------------------------------------------------------

I think the new tests in test_xhr_progressevents somewhat covers this case. Though it explicitly disables caching, so maybe it's best to take this one too.
Attachment #562268 - Flags: review?(jonas) → review+
Reporter

Updated

8 years ago
Keywords: checkin-needed
Whiteboard: [temp workaround to avoid disabling .responseType='blob']
https://hg.mozilla.org/mozilla-central/rev/fb91c8798858
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9

Updated

8 years ago
Whiteboard: [qa!]
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.