Closed Bug 669072 Opened 10 years ago Closed 10 years ago

Display results regardless of notes loading failure

Categories

(Tree Management Graveyard :: TBPL, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Swatinem, Assigned: Swatinem)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
No description provided.
Attachment #543675 - Flags: review?(mstange)
Why would that work? If starcomment.php is 404, then we wouldn't end up in the success callback at all, would we?
Hm it is for the case that we are in the sucess callback but the notes array is not an array but actually an object with {error: ...}
Attached patch v2Splinter Review
But you are right, it should handle both cases.
Attachment #543675 - Attachment is obsolete: true
Attachment #543677 - Flags: review?(mstange)
Attachment #543675 - Flags: review?(mstange)
Attachment #543677 - Flags: review?(mstange) → review+
Deployed via bug 683241.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.