Closed Bug 669234 Opened 10 years ago Closed 10 years ago
Restore to manage depth recursion tracking in ns SMILTimed Element
netwerk/base/src/nsIOService.cpp has an RAII-style AutoIncrement class that would be useful elsewhere. I'd like to move it to mfbt.
Assignee: nobody → birtles
Status: NEW → ASSIGNED
Proposed patch. dholbert has already given this r+ in bug 665334 but requesting review from cjones too.
Attachment #543842 - Flags: review?(jones.chris.g)
Comment on attachment 543842 [details] [diff] [review] Patch v1a, r=dholbert Hi Brian, I'm r-'ing this patch not because there are major problems with the impl, but because I'm not sure this is a common pattern across js/src and gecko. The pattern I've come across more commonly is . If AutoIncrement starts seeing use outside of the IO service, we can polish up it and revisit. CC'ing luke for a second opinion.  http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/AutoRestore.h#163
Attachment #543842 - Flags: review?(jones.chris.g) → review-
I agree with the general sentiment that its good to hoist lazily (when needed) vs. eagerly. I also agree that I can't think of any uses for AutoIncrement in SM; usually the ++/-- is part of some specific guard that does more than just ++/--.
(In reply to comment #2) >  > http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/AutoRestore.h#163 Much as I like the sleekness of AutoIncrement, I think that AutoRestore should serve our purposes equally well. Brian -- so it looks like we could replace your proposed... > AutoIncrement<PRUint16> inc(&mUpdateIntervalRecursionDepth); ...with... > AutoRestore<PRUint16> depthRestorer(mUpdateIntervalRecursionDepth); > mUpdateIntervalRecursionDepth++; Perhaps we should re-target this bug to be about that?
Thanks Chris and Luke. Fair call. I failed to point out that this wasn't just speculative; the reason for requesting it is that we need something like this in SMIL. However, as Daniel points out, the AutoRestore option Chris mentioned will do the trick. Thanks!
Component: General → SVG
QA Contact: general → general
Summary: Move AutoIncrement to mozilla/mfbt → Use AutoRestore to manage depth recursion tracking in nsSMILTimedElement
Attachment #544119 - Flags: review?(dholbert) → review+
Landed on m-c: http://hg.mozilla.org/mozilla-central/rev/e4a42cc36dc7
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.