Closed
Bug 669236
Opened 14 years ago
Closed 14 years ago
nsHTMLCanvasElement.cpp:734:12: warning: unused variable ‘rv’
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
VERIFIED
FIXED
People
(Reporter: dholbert, Unassigned)
References
(Blocks 1 open bug)
Details
(Whiteboard: [build_warning][inbound])
Attachments
(1 file)
|
1.11 KB,
patch
|
bas.schouten
:
review+
|
Details | Diff | Splinter Review |
New build warning from code introduced in bug 651858:
> mozilla/content/html/content/src/nsHTMLCanvasElement.cpp: In function ‘nsresult NS_NewCanvasRenderingContext2D(nsIDOMCanvasRenderingContext2D**)’:
> content/html/content/src/nsHTMLCanvasElement.cpp:734:12: warning: unused variable ‘rv’
The code is:
> 733 PRBool azure = PR_FALSE;
> 734 nsresult rv = Preferences::GetBool("gfx.canvas.azure.enabled", &azure);
> 735
> 736 if (azure) {
(and that |rv| is never read)
|
Reporter | |
Comment 1•14 years ago
|
||
|
||
Comment 2•14 years ago
|
||
Comment on attachment 543846 [details] [diff] [review]
fix
Review of attachment 543846 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #543846 -
Flags: review?(bas.schouten) → review+
|
||
Updated•14 years ago
|
Blocks: buildwarning
|
|
Reporter | |
Comment 3•14 years ago
|
||
Whiteboard: [build_warning] → [build_warning][inbound]
|
|
Reporter | |
Comment 4•14 years ago
|
||
I backed this out:
http://hg.mozilla.org/integration/mozilla-inbound/rev/0fd72ece7d13
because a wider-reaching cset simultaneously fixed this on mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/df68fdf2f727
Resolving as fixed by that other cset's bug. (bug 651858, the bug that added this code in the first place)
|
|
||
Comment 5•14 years ago
|
||
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0a2) Gecko/20110706 Firefox/7.0a2
Verified fixed (detailed in Comment 4).
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•