Closed Bug 669236 Opened 9 years ago Closed 9 years ago

nsHTMLCanvasElement.cpp:734:12: warning: unused variable ‘rv’

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

VERIFIED FIXED

People

(Reporter: dholbert, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [build_warning][inbound])

Attachments

(1 file)

New build warning from code introduced in bug 651858:

> mozilla/content/html/content/src/nsHTMLCanvasElement.cpp: In function ‘nsresult NS_NewCanvasRenderingContext2D(nsIDOMCanvasRenderingContext2D**)’:
> content/html/content/src/nsHTMLCanvasElement.cpp:734:12: warning: unused variable ‘rv’

The code is:
> 733   PRBool azure = PR_FALSE;
> 734   nsresult rv = Preferences::GetBool("gfx.canvas.azure.enabled", &azure);
> 735 
> 736   if (azure) {

(and that |rv| is never read)
Attached patch fixSplinter Review
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #543846 - Flags: review?(bas.schouten)
Comment on attachment 543846 [details] [diff] [review]
fix

Review of attachment 543846 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #543846 - Flags: review?(bas.schouten) → review+
I backed this out:
  http://hg.mozilla.org/integration/mozilla-inbound/rev/0fd72ece7d13
because a wider-reaching cset simultaneously fixed this on mozilla-central: 
  http://hg.mozilla.org/mozilla-central/rev/df68fdf2f727

Resolving as fixed by that other cset's bug. (bug 651858, the bug that added this code in the first place)
Assignee: dholbert → nobody
No longer blocks: 651858
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Depends on: 651858
Resolution: --- → FIXED
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0a2) Gecko/20110706 Firefox/7.0a2
Verified fixed (detailed in Comment 4).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.