Closed
Bug 669237
Opened 14 years ago
Closed 14 years ago
nsBuiltinDecoderReader.h init list out of order for VideoData::VideoData
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla7
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
(Whiteboard: [build_warning][inbound])
Attachments
(1 file)
|
1.01 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
Filing bug on this recently-introduced build warning, which shows up in every .cpp file to include nsBuiltinDecoderReader.h:
> In file included from nsBuiltinDecoderReader.cpp:44:0:
> nsBuiltinDecoderReader.h: In constructor ‘VideoData::VideoData(PRInt64, PRInt64, PRInt64, PRBool, PRInt64, nsIntSize)’:
> nsBuiltinDecoderReader.h:250:16: warning: ‘VideoData::mKeyframe’ will be initialized after
> nsBuiltinDecoderReader.h:229:13: warning: ‘nsIntSize VideoData::mDisplay’
> nsBuiltinDecoderReader.h:265:3: warning: when initialized here
Introduced by http://hg.mozilla.org/mozilla-central/rev/6d87b94b1b12 (bug 661456), which added mDisplay as the first variable in the class declaration, but initializes it last in the constructor's init list.
|
Assignee | |
Comment 1•14 years ago
|
||
Confirmed locally that this fixes the build warning.
|
||
Updated•14 years ago
|
Attachment #543845 -
Flags: review?(chris) → review+
|
|
Assignee | |
Comment 2•14 years ago
|
||
OS: Linux → All
Hardware: x86 → All
Whiteboard: [build_warning] → [build_warning][inbound]
|
||
Comment 3•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in
before you can comment on or make changes to this bug.
Description
•