Last Comment Bug 669299 - uneeded nsPrintfCString.h includes
: uneeded nsPrintfCString.h includes
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla8
Assigned To: arno renevier
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-05 06:53 PDT by arno renevier
Modified: 2011-07-20 19:49 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch v1 (16.27 KB, patch)
2011-07-05 06:54 PDT, arno renevier
no flags Details | Diff | Splinter Review
patch v1.1 (15.95 KB, patch)
2011-07-06 00:04 PDT, arno renevier
benjamin: review+
Details | Diff | Splinter Review

Description arno renevier 2011-07-05 06:53:31 PDT
Hi,
nsPrintfCString.h defines only one class: nsPrintfCString. Therefore, when a file include nsPrintfCString.h but uses nsPrintfCString nowhere, it's unneeded.
There is currently the case in many files: https://mxr.mozilla.org/mozilla-central/search?string=nsPrintfCString
Comment 1 arno renevier 2011-07-05 06:54:18 PDT
Created attachment 543926 [details] [diff] [review]
patch v1
Comment 2 arno renevier 2011-07-06 00:04:52 PDT
Created attachment 544163 [details] [diff] [review]
patch v1.1

same patch with a commit message
Comment 3 :Ms2ger 2011-07-20 12:55:41 PDT
Btw, a commit message needs to include the bug number and the reviewer. Something like 

Bug 669299 - Remove unneeded nsPrintfCString.h includes; r=bsmedberg

for example.
Comment 4 Dão Gottwald [:dao] 2011-07-20 19:49:01 PDT
http://hg.mozilla.org/mozilla-central/rev/6df31af4cca6

Note You need to log in before you can comment on or make changes to this bug.