The default bug view has changed. See this FAQ.

uneeded nsPrintfCString.h includes

RESOLVED FIXED in mozilla8

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: arno renevier, Assigned: arno renevier)

Tracking

unspecified
mozilla8
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

15.95 KB, patch
bsmedberg
: review+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
Hi,
nsPrintfCString.h defines only one class: nsPrintfCString. Therefore, when a file include nsPrintfCString.h but uses nsPrintfCString nowhere, it's unneeded.
There is currently the case in many files: https://mxr.mozilla.org/mozilla-central/search?string=nsPrintfCString
(Assignee)

Comment 1

6 years ago
Created attachment 543926 [details] [diff] [review]
patch v1
Assignee: nobody → arno
Attachment #543926 - Flags: review?(benjamin)
(Assignee)

Comment 2

6 years ago
Created attachment 544163 [details] [diff] [review]
patch v1.1

same patch with a commit message
Attachment #543926 - Attachment is obsolete: true
Attachment #544163 - Flags: review?(benjamin)
Attachment #543926 - Flags: review?(benjamin)
Attachment #544163 - Flags: review?(benjamin) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
Btw, a commit message needs to include the bug number and the reviewer. Something like 

Bug 669299 - Remove unneeded nsPrintfCString.h includes; r=bsmedberg

for example.
http://hg.mozilla.org/mozilla-central/rev/6df31af4cca6
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.