Closed
Bug 669299
Opened 14 years ago
Closed 14 years ago
uneeded nsPrintfCString.h includes
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla8
People
(Reporter: arno, Assigned: arno)
Details
Attachments
(1 file, 1 obsolete file)
|
15.95 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
Hi,
nsPrintfCString.h defines only one class: nsPrintfCString. Therefore, when a file include nsPrintfCString.h but uses nsPrintfCString nowhere, it's unneeded.
There is currently the case in many files: https://mxr.mozilla.org/mozilla-central/search?string=nsPrintfCString
|
Assignee | |
Comment 1•14 years ago
|
||
Assignee: nobody → arno
Attachment #543926 -
Flags: review?(benjamin)
|
|
Assignee | |
Comment 2•14 years ago
|
||
same patch with a commit message
Attachment #543926 -
Attachment is obsolete: true
Attachment #544163 -
Flags: review?(benjamin)
Attachment #543926 -
Flags: review?(benjamin)
|
||
Updated•14 years ago
|
Attachment #544163 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 3•14 years ago
|
||
Btw, a commit message needs to include the bug number and the reviewer. Something like
Bug 669299 - Remove unneeded nsPrintfCString.h includes; r=bsmedberg
for example.
|
||
Comment 4•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
|
||
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•