Closed Bug 669299 Opened 10 years ago Closed 10 years ago

uneeded nsPrintfCString.h includes

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla8

People

(Reporter: arno, Assigned: arno)

Details

Attachments

(1 file, 1 obsolete file)

Hi,
nsPrintfCString.h defines only one class: nsPrintfCString. Therefore, when a file include nsPrintfCString.h but uses nsPrintfCString nowhere, it's unneeded.
There is currently the case in many files: https://mxr.mozilla.org/mozilla-central/search?string=nsPrintfCString
Attached patch patch v1 (obsolete) — Splinter Review
Assignee: nobody → arno
Attachment #543926 - Flags: review?(benjamin)
Attached patch patch v1.1Splinter Review
same patch with a commit message
Attachment #543926 - Attachment is obsolete: true
Attachment #544163 - Flags: review?(benjamin)
Attachment #543926 - Flags: review?(benjamin)
Attachment #544163 - Flags: review?(benjamin) → review+
Keywords: checkin-needed
Btw, a commit message needs to include the bug number and the reviewer. Something like 

Bug 669299 - Remove unneeded nsPrintfCString.h includes; r=bsmedberg

for example.
http://hg.mozilla.org/mozilla-central/rev/6df31af4cca6
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.