669366 - Handle negative arguments to drawImage

Status: VERIFIED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[LegNeato]

+++ This bug was initially created as a clone of Bug #629875 +++

http://www.w3c-test.org/html/tests/submission/PhilipTaylor/canvas/2d.drawImage.negativedest.html
http://www.w3c-test.org/html/tests/submission/PhilipTaylor/canvas/2d.drawImage.negativedir.html
http://www.w3c-test.org/html/tests/submission/PhilipTaylor/canvas/2d.drawImage.negativesource.html

We need to figure out if we want the backout on Aurora as we didn't transplant anything in the source migration (didn't transplant cleanly)

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

So, should we get attachment 533887 [details] [diff] [review] reviewed and landed?

Comment 2

[Asa Dotzler [:asa]]

JP, can you help find the right people to look at this?

Comment 3

[JP Rosevear [:jpr]]

Jeff probably has the most context.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Yes, I believe we should land the backout on Aurora. I'll take a closer look at this today.

Comment 5

[Bas Schouten (:bas.schouten)]

Attachment: Switch Azure to old behavior

This patch will switch Azure to the old behavior.

Comment 6

[Joe Drew (not getting mail)]

I pushed this and the reversion of bug 629875 to aurora:

http://hg.mozilla.org/releases/mozilla-aurora/rev/20e76c984d82

and to inbound:

http://hg.mozilla.org/integration/mozilla-inbound/rev/b9ad0b9119b7

Comment 7

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/b9ad0b9119b7

Comment 8

[Eric Shepherd [:sheppy]]

This was documented a while ago.

Comment 9

[u279076]

qa+ for verification in Firefox 7

Comment 10

[Simona Badau, Desktop QA]

Verified using the links from the description in Win XP, Win 7, Mac OS X 10.6 and Ubuntu 11.04 on Firefox 7RC, Aurora and the latest Nightly. On all of the 3 links the results are Failed on a red Background, this is the intended behavior as this is a backout.

Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (Windows NT 6.1; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:7.0) Gecko/20100101 Firefox/7.0

Mozilla/5.0 (Windows NT 5.1; rv:8.0a2) Gecko/20110921 Firefox/8.0a2
Mozilla/5.0 (Windows NT 6.1; rv:8.0a2) Gecko/20110921 Firefox/8.0a2
Mozilla/5.0 (X11; Linux x86_64; rv:8.0a2) Gecko/20110921 Firefox/8.0a2
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:8.0a2) Gecko/20110921 Firefox/8.0a2

Mozilla/5.0 (Windows NT 5.1; rv:9.0a1) Gecko/20110922 Firefox/9.0a1
Mozilla/5.0 (Windows NT 6.1; rv:9.0a1) Gecko/20110922 Firefox/9.0a1
Mozilla/5.0 (X11; Linux x86_64; rv:9.0a1) Gecko/20110922 Firefox/9.0a1
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0a1) Gecko/20110923 Firefox/9.0a1