Last Comment Bug 669403 - Build both VC9 and VC10 exception-wrapping code
: Build both VC9 and VC10 exception-wrapping code
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86 Windows 7
: -- normal (vote)
: mozilla9
Assigned To: Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-05 11:51 PDT by Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
Modified: 2011-09-01 01:47 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Always build both VC9 and VC10 exception-wrapping hackery into the Gecko SDK (295 bytes, patch)
2011-07-05 14:02 PDT, Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
no flags Details | Diff | Review
Always build both VC9 and VC10 exception-wrapping hackery into the Gecko SDK (2.19 KB, patch)
2011-07-05 20:34 PDT, Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
benjamin: review+
Details | Diff | Review

Description Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-07-05 11:51:31 PDT
It was reported on m.d.build that our SDK doesn't build with VC10, because of our exception-wrapping code.  The problem is that we conditionally include the VC9 or VC10 headers/sources, and that depends on the machine the SDK was packaged on.  Hopefully we can move to VC10 ASAP, but in the meantime we should just build both into gecko.  They shouldn't conflict, in theory.
Comment 1 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-07-05 14:02:50 PDT
Created attachment 544055 [details] [diff] [review]
Always build both VC9 and VC10 exception-wrapping hackery into the Gecko SDK
Comment 2 Siddharth Agarwal [:sid0] (inactive) 2011-07-05 16:10:02 PDT
the actual patch is missing :)
Comment 3 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-07-05 20:34:04 PDT
Created attachment 544134 [details] [diff] [review]
Always build both VC9 and VC10 exception-wrapping hackery into the Gecko SDK

Oops, thanks.  Looks like hg let me qnew with unsaved changes.
Comment 4 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-08-31 11:06:33 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/5c4506fdbde9
Comment 5 Ed Morley [:emorley] 2011-09-01 01:47:07 PDT
http://hg.mozilla.org/mozilla-central/rev/5c4506fdbde9

Note You need to log in before you can comment on or make changes to this bug.