669403 - Build both VC9 and VC10 exception-wrapping code

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

It was reported on m.d.build that our SDK doesn't build with VC10, because of our exception-wrapping code.  The problem is that we conditionally include the VC9 or VC10 headers/sources, and that depends on the machine the SDK was packaged on.  Hopefully we can move to VC10 ASAP, but in the meantime we should just build both into gecko.  They shouldn't conflict, in theory.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Always build both VC9 and VC10 exception-wrapping hackery into the Gecko SDK

Comment 2

[Rain [:rain1] (inactive)]

the actual patch is missing :)

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Always build both VC9 and VC10 exception-wrapping hackery into the Gecko SDK

Oops, thanks.  Looks like hg let me qnew with unsaved changes.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

http://hg.mozilla.org/integration/mozilla-inbound/rev/5c4506fdbde9

Comment 5

[Ed Morley [:emorley]]

http://hg.mozilla.org/mozilla-central/rev/5c4506fdbde9