Closed Bug 669403 Opened 9 years ago Closed 9 years ago

Build both VC9 and VC10 exception-wrapping code

Categories

(Firefox Build System :: General, defect)

x86
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla9

People

(Reporter: cjones, Assigned: cjones)

Details

Attachments

(1 file, 1 obsolete file)

It was reported on m.d.build that our SDK doesn't build with VC10, because of our exception-wrapping code.  The problem is that we conditionally include the VC9 or VC10 headers/sources, and that depends on the machine the SDK was packaged on.  Hopefully we can move to VC10 ASAP, but in the meantime we should just build both into gecko.  They shouldn't conflict, in theory.
Assignee: nobody → jones.chris.g
Attachment #544055 - Flags: review?(benjamin)
the actual patch is missing :)
Oops, thanks.  Looks like hg let me qnew with unsaved changes.
Attachment #544055 - Attachment is obsolete: true
Attachment #544134 - Flags: review?(benjamin)
Attachment #544055 - Flags: review?(benjamin)
Attachment #544134 - Flags: review?(benjamin) → review+
http://hg.mozilla.org/mozilla-central/rev/5c4506fdbde9
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla9
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.