Closed Bug 669409 Opened 8 years ago Closed 8 years ago

Fullscreen HTML5 video error: Component returned failure code: 0x80004002 (NS_NOINTERFACE) [nsISupports.QueryInterface] @ [content.js::receiveMessage]

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 8

People

(Reporter: aaronmt, Assigned: Ms2ger)

References

()

Details

Attachments

(1 file)

Mozilla/5.0 (ANdroid; Linux armv7l; rv:7.0a1) Gecko/20110705 Firefox/7.0a1 Fennec/7.0a1
Device: HTC Nexus One, Samsung Nexus S
Android: 2.3.4

STR: 
1. http://double.co.nz/video_test/test5.html
2. Tap press-hold, select 'Fullscreen Video'

uncaught exception: [Exception... "Component returned failure code: 0x80004002 (NS_NOINTERFACE) [nsISupports.QueryInterface]"  nsresult: "0x80004002 (NS_NOINTERFACE)"  location: "JS frame :: chrome://browser/content/content.js :: receiveMessage :: line 405"  data: no]
if (!wrappedTarget)
  break;
let target = wrappedTarget.QueryInterface(Ci.nsIDOMNSEditableElement);
if (!target)
  break;

is wrong. It should be

if (!wrappedTarget || !(wrappedTarget instanceof Ci.nsIDOMNSEditableElement))
  break;

let target = wrappedTarget.QueryInterface(Ci.nsIDOMNSEditableElement);

Seems like the same error is present in _setMinFontSize.
The exception also occurs with copying text from pastebin.mozilla.org.
I'm also seeing this with Play/Pause on the video.
I used this video: http://dl1.hidrop.com/temp/mobile/big_buck_bunny_480p.webm

Besides the error message regarding this bug on full screen video, I'm also seeing this error in the error console a bunch of times on full screen:
aTab is null
chrome://browser/content/browser.js
1518
Attached patch patchSplinter Review
Your suggestion works, Ms2ger, thanks.
I didn't see anything related in _setMinFontSize. Perhaps that code has already changed?

After this patch, the aTab is null error is still there.
Attachment #551903 - Flags: review?(Ms2ger)
Note that I was seeing this error occuring while pasting some text in the input box in google.
Comment on attachment 551903 [details] [diff] [review]
patch

Looks good to me, but I'm not a peer.

In _setMinFontSize, the null-check is superfluous, but that's not really a problem.
Attachment #551903 - Flags: review?(mbrubeck)
Attachment #551903 - Flags: review?(Ms2ger)
Attachment #551903 - Flags: feedback+
Thanks, I was planning on asking review from a peer, too, but I just wanted to make sure this is what you meant.
Attachment #551903 - Flags: review?(mbrubeck) → review+
Assignee: nobody → Ms2ger
Keywords: checkin-needed
After long tapping and placing the video in full screen mode, long tapping again will cause the error and the aTab, tab errors to appear again.
tracking-fennec: --- → ?
The patch hasn't landed on mozilla-central yet.
Merged:
http://hg.mozilla.org/mozilla-central/rev/609f37c36bd7
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8
Verified Fixed
Mozilla/5.0 (Android; Linux armv7l; rv:8.0a1) Gecko/20110812 Firefox/8.0a1 Fennec/8.0a1
Status: RESOLVED → VERIFIED
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.