jstests.py fails when testing XUL condition '!xulRuntime.shell'

UNCONFIRMED
Unassigned

Status

()

UNCONFIRMED
8 years ago
8 years ago

People

(Reporter: taustin, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

866 bytes, text/plain
Details
(Reporter)

Description

8 years ago
Created attachment 544100 [details]
Patch file

I believe this is related to bug 644697.

Running Narcissus with jstests.py fails with Tracemonkey branch (though I think the issue is larger than Narcissus).  Here is the error:

Traceback (most recent call last):
  File "/Users/taustin/mozilla/tracemonkey/js/src/tests/jstests.py", line 309, in <module>
    test_list = manifest.parse(OPTIONS.manifest, xul_tester)
  File "/Users/taustin/mozilla/tracemonkey/js/src/tests/manifest.py", line 125, in parse
    ans += parse(os.path.join(dir, include_file), xul_tester, include_reldir)
  File "/Users/taustin/mozilla/tracemonkey/js/src/tests/manifest.py", line 125, in parse
    ans += parse(os.path.join(dir, include_file), xul_tester, include_reldir)
  File "/Users/taustin/mozilla/tracemonkey/js/src/tests/manifest.py", line 159, in parse
    if xul_tester.test(cond):
  File "/Users/taustin/mozilla/tracemonkey/js/src/tests/manifest.py", line 96, in test
    % (cond, out, err))
Exception: Failed to test XUL condition '!xulRuntime.shell'; output was '', stderr was ':1: ReferenceError: False is not defined\n'


A patch is attached.  The key change to manifest.py is listed here, for convenience:
-            self.os == "Android")
+            str(self.os == "Android").lower())
You need to log in before you can comment on or make changes to this bug.