Closed
Bug 669616
Opened 13 years ago
Closed 13 years ago
Audio controls : duration are inaccurate.
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: padenot, Assigned: padenot)
Details
Attachments
(1 file)
|
2.42 KB,
patch
|
Dolske
:
review+
|
Details | Diff | Splinter Review |
In http://tbpl.mozilla.org/?tree=Try&rev=e8e3ba577ba7, the accuracy of the duration label has been questioned. Citing dolke : > The right way to fix this is to round |time| to the nearest full-second value. > (Or Math.round() for |secs| only, and fixup for the special case of secs==60, > but that sounds more complex).
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → paul
|
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #544233 -
Flags: review?(dolske)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 544233 [details] [diff] [review] Patch v0 - Fix roudings. Review of attachment 544233 [details] [diff] [review]: ----------------------------------------------------------------- Nice catch! :)
Attachment #544233 -
Flags: review?(dolske) → review+
|
|
Assignee | |
Updated•13 years ago
|
Component: Video/Audio → Web Services
Keywords: checkin-needed
|
||
Updated•13 years ago
|
Assignee: paul → nobody
Component: Web Services → Video/Audio
|
||
Comment 3•13 years ago
|
||
Comment on attachment 544233 [details] [diff] [review] Patch v0 - Fix roudings. ># HG changeset patch ># Parent f475d7fdf8322d88be7395779df3ea679b7f1bfa ># User Paul ADENOT <paul@paul.cx> >Bug 669616 - Audio controls : duration are inaccurate. For future reference - it's preferable to describe the change in the commit message, rather than describing the problem. Tweaked commit message using the description in comment 0, and pushed to m-i: http://hg.mozilla.org/integration/mozilla-inbound/rev/67397e750a3a
|
|
||
Updated•13 years ago
|
|
|
||
Updated•13 years ago
|
Assignee: nobody → paul
Status: NEW → ASSIGNED
|
||
Comment 4•13 years ago
|
||
Merged: http://hg.mozilla.org/mozilla-central/rev/67397e750a3a
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•