The default bug view has changed. See this FAQ.

Audio controls : duration are inaccurate.

RESOLVED FIXED in mozilla8

Status

()

Core
Audio/Video
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: padenot, Assigned: padenot)

Tracking

Trunk
mozilla8
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
In http://tbpl.mozilla.org/?tree=Try&rev=e8e3ba577ba7, the accuracy of the duration label has been questioned.

Citing dolke : 

> The right way to fix this is to round |time| to the nearest full-second value. > (Or Math.round() for |secs| only, and fixup for the special case of secs==60, 
> but that sounds more complex).
(Assignee)

Updated

6 years ago
Assignee: nobody → paul
(Assignee)

Comment 1

6 years ago
Created attachment 544233 [details] [diff] [review]
Patch v0 - Fix roudings.
Attachment #544233 - Flags: review?(dolske)
Comment on attachment 544233 [details] [diff] [review]
Patch v0 - Fix roudings.

Review of attachment 544233 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch! :)
Attachment #544233 - Flags: review?(dolske) → review+
(Assignee)

Updated

6 years ago
Component: Video/Audio → Web Services
Keywords: checkin-needed
Assignee: paul → nobody
Component: Web Services → Video/Audio
Comment on attachment 544233 [details] [diff] [review]
Patch v0 - Fix roudings.

># HG changeset patch
># Parent f475d7fdf8322d88be7395779df3ea679b7f1bfa
># User Paul ADENOT <paul@paul.cx>
>Bug 669616 - Audio controls : duration are inaccurate.

For future reference - it's preferable to describe the change in the commit message, rather than describing the problem.

Tweaked commit message using the description in comment 0, and pushed to m-i:
http://hg.mozilla.org/integration/mozilla-inbound/rev/67397e750a3a
Keywords: checkin-needed
Whiteboard: [inbound]
Version: unspecified → Trunk
Assignee: nobody → paul
Status: NEW → ASSIGNED
Merged:
http://hg.mozilla.org/mozilla-central/rev/67397e750a3a
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.