669616 - Audio controls : duration are inaccurate.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Paul Adenot (:padenot)]

In http://tbpl.mozilla.org/?tree=Try&rev=e8e3ba577ba7, the accuracy of the duration label has been questioned.

Citing dolke : 

> The right way to fix this is to round |time| to the nearest full-second value. > (Or Math.round() for |secs| only, and fixup for the special case of secs==60, 
> but that sounds more complex).

Comment 1

[Paul Adenot (:padenot)]

Attachment: Patch v0 - Fix roudings.

Comment 2

[Justin Dolske [:Dolske]]

Comment on attachment 544233 [details] [diff] [review]
Patch v0 - Fix roudings.

Review of attachment 544233 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch! :)

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 544233 [details] [diff] [review]
Patch v0 - Fix roudings.

># HG changeset patch
># Parent f475d7fdf8322d88be7395779df3ea679b7f1bfa
># User Paul ADENOT <[e-mail]>
>Bug 669616 - Audio controls : duration are inaccurate.

For future reference - it's preferable to describe the change in the commit message, rather than describing the problem.

Tweaked commit message using the description in comment 0, and pushed to m-i:
http://hg.mozilla.org/integration/mozilla-inbound/rev/67397e750a3a

Comment 4

[Mounir Lamouri (:mounir)]

Merged:
http://hg.mozilla.org/mozilla-central/rev/67397e750a3a