669641 - Profile sanitizer should clear syncAccount first

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Philipp von Weitershausen [:philikon]]

It's great that the profile sanitizer calls Weave.Service.startOver() (via WeaveGlue.disconnect()), but it does that *last*, after wiping history and password and other things.

First of all, wiping history will now trigger a sync very quickly (bug 600429) and bug 665965), so the deletion may be propagated to other devices.

Secondly, wiping passwords will also wipe Sync credential data (the Sync password and Sync Key), so in fact the Sync sanitizer will never ever be called because its canClear getter will always return false.

I would recommend clearing syncAccount first.

Comment 1

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Comment 2

[Philipp von Weitershausen [:philikon]]

http://hg.mozilla.org/services/services-central/rev/c37b4fa38e69

Comment 3

[Philipp von Weitershausen [:philikon]]

STRs for QA:

* Set up Sync on Fennec, open a few tabs, verify the tabs show up on another device.
* Click the "Clear All Private Data" button in Fennec. This should remove the device-specific records (=tabs) from your Sync account.
* Verify the phone's tabs no longer show up on other devices.

Comment 4

[Tony Chung [:tchung]]

This is not working correctly.  Following the STR in comment 3 to the dot, the tabs from my Nexus S still appear on my Desktop browser after CPD on the phone.  What am i missing?

Fennec build installed from: http://hg.mozilla.org/services/services-central/rev/8f022250cf92

Comment 5

[Philipp von Weitershausen [:philikon]]

Merged to m-c: http://hg.mozilla.org/mozilla-central/rev/c37b4fa38e69

Not resolving as per comment 4.

Comment 6

[BMO Automation]

Closing all opened bug in a graveyard component