Closed Bug 669670 Opened 13 years ago Closed 13 years ago

Remove workaround for getOwnPropertyDescriptor from chrome code

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 8

People

(Reporter: past, Assigned: past)

Details

Attachments

(1 file)

[in-fx-team] Patch v1
2.70 KB, patch
msucan
: review+
mossop
: review+
Details | Diff | Splinter Review 
In bug 651501 I used the pattern scope.Object.getOwnPropertyDescriptor to work around a platform bug. Since bug 664689 was fixed we no longer need this, which would simplify our code a bit.
Assignee: nobody → past
Status: NEW → ASSIGNED

        Attachment #544273 -
        Flags: review?(mihai.sucan)

    
    

    
  
Comment on attachment 544273 [details] [diff] [review]
[in-fx-team] Patch v1

This looks fine. All tests pass locally!

        Attachment #544273 -
        Flags: review?(mihai.sucan) → review+

    
    

    
  
Comment on attachment 544273 [details] [diff] [review]
[in-fx-team] Patch v1

Thank you Mihai!
Dave can you review this cleanup of the patch you reviewed for bug 651501?

        Attachment #544273 -
        Flags: review?(dtownsend)

        Attachment #544273 -
        Flags: review?(dtownsend) → review+
Whiteboard: [land-in-fx-team]

    
    

    
  
Comment on attachment 544273 [details] [diff] [review]
[in-fx-team] Patch v1

Pushed to:

http://hg.mozilla.org/integration/fx-team/rev/bad869718019

        Attachment #544273 -
        Attachment description: Patch v1 → [in-fx-team] Patch v1
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 8

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: