669719 - the <math/> element does not support the displaystyle attribute

Status: RESOLVED FIXED

Description

[Frédéric Wang (:fredw)]

In bug 569124, we allowed the <math/> element to behave as a <mstyle/>. The displaystyle attribute, handled in the nsMathMLmstyleFrame, was however not taken into account in this change.

A possible fix: in nsMathMLFrame::GetPresentationDataFrom, after setting aPresentationData.flags according to display->mDisplay, we can add a call to nsMathMLFrame::FindAttrDisplaystyle, so that we will look to a possible displaystyle attribute on the <math/> element.

See the testcase, which can easily be converted into a == reftest.

Comment 1

[Frédéric Wang (:fredw)]

I forgot to attach a testcase. The idea was simply to compare

<math displaystyle="true">
  ...
</math>

and

<math>
  <mstyle displaystyle="true">
    ...
  </mstyle>
</math>

where ... are elements rendered differently in displaystyle = true/false

Comment 2

[Jonathan Hage]

Created attachment 544790 [details] [diff] [review]
Patch

Comment 3

[Jonathan Hage]

Created attachment 544791 [details] [diff] [review]
Reftests

Comment 4

[Jonathan Hage]

Created attachment 544797 [details] [diff] [review]
Reftests

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 544790 [details] [diff] [review]
Patch

Review of attachment 544790 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 544797 [details] [diff] [review]
Reftests

Review of attachment 544797 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 7

[Dão Gottwald [::dao]]

http://hg.mozilla.org/mozilla-central/rev/5d92749612cc

Comment 8

[Dão Gottwald [::dao]]

backed out for crashtest failures: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1310221738.1310222230.5384.gz&fulltext=1

Comment 9

[Frédéric Wang (:fredw)]

We need to update nsMathMLFrame::FindAttrDisplaystyle, now that <math/> is allowed to have the displaystyle attribute:

http://mxr.mozilla.org/mozilla-central/source/layout/mathml/nsMathMLFrame.cpp#65

Comment 10

[Jonathan Hage]

Created attachment 545130 [details] [diff] [review]
Patch

Comment 11

[Jonathan Hage]

Created attachment 545131 [details] [diff] [review]
Code

Comment 12

[Frédéric Wang (:fredw)]

(In reply to comment #11)
> Created attachment 545131 [details] [diff] [review] [review]
> Code

I ran the crashtests with a debug build. The only failing test I have is

parser/htmlparser/tests/crashtests/445171-1.html

but that does not seem related to this patch.

Comment 13

[Boris Zbarsky [:bz] (work week until 5/26) (if a patch has no decent message, automatic r-)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/91740322b888

Comment 14

[:Ehsan Akhgari (needinfo please, extremely long backlog)]

http://hg.mozilla.org/mozilla-central/rev/91740322b888

Comment 15

[Florian Scholz [:fscholz] (MDN)]

Updated docs:
https://developer.mozilla.org/en/Firefox_8_for_developers#MathML
https://developer.mozilla.org/en/MathML/Element/math#Gecko-specific_notes