the <math/> element does not support the displaystyle attribute
RESOLVED
FIXED
in mozilla8
Status
()
People
(Reporter: fredw, Assigned: hage.jonathan)
Tracking
({dev-doc-complete})
Bug Flags:
Firefox Tracking Flags
(Not tracked)
Details
(Whiteboard: [good first bug])
Attachments
(2 attachments, 3 obsolete attachments)
|
1.51 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
|
2.38 KB,
patch
|
Details | Diff | Splinter Review |
In bug 569124, we allowed the <math/> element to behave as a <mstyle/>. The displaystyle attribute, handled in the nsMathMLmstyleFrame, was however not taken into account in this change. A possible fix: in nsMathMLFrame::GetPresentationDataFrom, after setting aPresentationData.flags according to display->mDisplay, we can add a call to nsMathMLFrame::FindAttrDisplaystyle, so that we will look to a possible displaystyle attribute on the <math/> element. See the testcase, which can easily be converted into a == reftest.
|
(Reporter) | |
Comment 1•8 years ago
|
||
I forgot to attach a testcase. The idea was simply to compare
<math displaystyle="true">
...
</math>
and
<math>
<mstyle displaystyle="true">
...
</mstyle>
</math>
where ... are elements rendered differently in displaystyle = true/false
|
(Assignee) | |
Comment 2•8 years ago
|
||
|
|
(Assignee) | |
Comment 3•8 years ago
|
||
|
|
(Assignee) | |
Comment 4•8 years ago
|
||
Attachment #544791 -
Attachment is obsolete: true
|
|
(Assignee) | |
Updated•8 years ago
|
Attachment #544790 -
Flags: review?(roc)
|
|
(Assignee) | |
Updated•8 years ago
|
Attachment #544797 -
Flags: review?(roc)
Comment on attachment 544790 [details] [diff] [review] Patch Review of attachment 544790 [details] [diff] [review]: -----------------------------------------------------------------
Attachment #544790 -
Flags: review?(roc) → review+
Comment on attachment 544797 [details] [diff] [review] Reftests Review of attachment 544797 [details] [diff] [review]: -----------------------------------------------------------------
Attachment #544797 -
Flags: review?(roc) → review+
|
|
(Reporter) | |
Updated•8 years ago
|
Keywords: checkin-needed
|
||
Updated•8 years ago
|
Assignee: nobody → hage.jonathan
|
|
||
Updated•8 years ago
|
Keywords: helpwanted
|
|
(Reporter) | |
Updated•8 years ago
|
Status: NEW → ASSIGNED
|
|
||
Comment 7•8 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/5d92749612cc
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
|
|
||
Comment 8•8 years ago
|
||
backed out for crashtest failures: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1310221738.1310222230.5384.gz&fulltext=1
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
||
Updated•8 years ago
|
Target Milestone: mozilla8 → ---
|
|
(Reporter) | |
Comment 9•8 years ago
|
||
We need to update nsMathMLFrame::FindAttrDisplaystyle, now that <math/> is allowed to have the displaystyle attribute: http://mxr.mozilla.org/mozilla-central/source/layout/mathml/nsMathMLFrame.cpp#65
|
|
(Assignee) | |
Comment 10•8 years ago
|
||
Attachment #544790 -
Attachment is obsolete: true
|
|
(Assignee) | |
Comment 11•8 years ago
|
||
Attachment #545130 -
Attachment is obsolete: true
|
|
(Reporter) | |
Comment 12•8 years ago
|
||
(In reply to comment #11) > Created attachment 545131 [details] [diff] [review] [review] > Code I ran the crashtests with a debug build. The only failing test I have is parser/htmlparser/tests/crashtests/445171-1.html but that does not seem related to this patch.
|
|
(Reporter) | |
Updated•8 years ago
|
Keywords: checkin-needed
|
||
Comment 13•8 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/91740322b888
Keywords: checkin-needed
|
||
Comment 14•8 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/91740322b888
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago → 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
|
||
Updated•8 years ago
|
Keywords: dev-doc-needed
|
||
Comment 15•8 years ago
|
||
Updated docs: https://developer.mozilla.org/en/Firefox_8_for_developers#MathML https://developer.mozilla.org/en/MathML/Element/math#Gecko-specific_notes
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•