Closed Bug 669719 Opened 9 years ago Closed 9 years ago

the <math/> element does not support the displaystyle attribute

Categories

(Core :: MathML, defect)

Product:
Core
Component:
MathML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla8

People

(Reporter: fredw, Assigned: hage.jonathan)

References

Details

(Keywords: dev-doc-complete, Whiteboard: [good first bug])

Attachments

(2 files, 3 obsolete files)

Reftests
1.51 KB, patch
roc
: review+
Details | Diff | Splinter Review
Code
2.38 KB, patch
Details | Diff | Splinter Review 
In bug 569124, we allowed the <math/> element to behave as a <mstyle/>. The displaystyle attribute, handled in the nsMathMLmstyleFrame, was however not taken into account in this change.

A possible fix: in nsMathMLFrame::GetPresentationDataFrom, after setting aPresentationData.flags according to display->mDisplay, we can add a call to nsMathMLFrame::FindAttrDisplaystyle, so that we will look to a possible displaystyle attribute on the <math/> element.

See the testcase, which can easily be converted into a == reftest.
I forgot to attach a testcase. The idea was simply to compare

<math displaystyle="true">
  ...
</math>

and

<math>
  <mstyle displaystyle="true">
    ...
  </mstyle>
</math>

where ... are elements rendered differently in displaystyle = true/false
Attached patch Patch (obsolete) — — Splinter Review
Attached patch Reftests (obsolete) — — Splinter Review
Attached patch Reftests — — Splinter Review
Attachment #544791 - Attachment is obsolete: true
Attachment #544790 - Flags: review?(roc)
Attachment #544797 - Flags: review?(roc)
Comment on attachment 544790 [details] [diff] [review]
Patch

Review of attachment 544790 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #544790 - Flags: review?(roc) → review+
Comment on attachment 544797 [details] [diff] [review]
Reftests

Review of attachment 544797 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #544797 - Flags: review?(roc) → review+
Keywords: checkin-needed
Assignee: nobody → hage.jonathan
Keywords: helpwanted
Status: NEW → ASSIGNED
http://hg.mozilla.org/mozilla-central/rev/5d92749612cc
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
backed out for crashtest failures: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1310221738.1310222230.5384.gz&fulltext=1
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla8 → ---
We need to update nsMathMLFrame::FindAttrDisplaystyle, now that <math/> is allowed to have the displaystyle attribute:

http://mxr.mozilla.org/mozilla-central/source/layout/mathml/nsMathMLFrame.cpp#65
Attached patch Patch (obsolete) — — Splinter Review
Attachment #544790 - Attachment is obsolete: true
Attached patch Code — — Splinter Review
Attachment #545130 - Attachment is obsolete: true
(In reply to comment #11)
> Created attachment 545131 [details] [diff] [review] [review]
> Code

I ran the crashtests with a debug build. The only failing test I have is

parser/htmlparser/tests/crashtests/445171-1.html

but that does not seem related to this patch.
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/91740322b888
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.