Closed Bug 669722 Opened 9 years ago Closed 8 years ago

update-verify-bump.pl incorrectly removes the previous release when oldVersion=5.0

Categories

(Release Engineering :: General, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: Callek)

References

Details

(Whiteboard: [release-process-improvement][automation][updates])

Attachments

(1 file)

We check the first line of an update verify to see if we need to remove the previous version before bumping. The first line is a comment with the version of previous release. This all worked fine until recently, when we've stopped using the "rc" moniker in version numbers. Now, when this comparison happens, it matches, because eg, "# 5.0b7 - linux" =~ "5.0" is true:
  if ($origFile[0] =~ $oldVersion)

The simple fix for this is getting pickier about what we match here. Better fix would be checking the actual data line's version/buildid, might not be worth the trouble though.
OS: Linux → All
Priority: -- → P3
Hardware: x86_64 → All
Whiteboard: [release-process-improvement][automation][updates]
Assignee: nobody → bugspam.Callek
Priority: P3 → P2
Attached patch v1Splinter Review
Attachment #596489 - Flags: review?(bhearsum)
Comment on attachment 596489 [details] [diff] [review]
v1

Review of attachment 596489 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, I think this works...
Attachment #596489 - Flags: review?(bhearsum) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.