update-verify-bump.pl incorrectly removes the previous release when oldVersion=5.0

RESOLVED FIXED

Status

Release Engineering
General
P2
normal
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: bhearsum, Assigned: Callek)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [release-process-improvement][automation][updates])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
We check the first line of an update verify to see if we need to remove the previous version before bumping. The first line is a comment with the version of previous release. This all worked fine until recently, when we've stopped using the "rc" moniker in version numbers. Now, when this comparison happens, it matches, because eg, "# 5.0b7 - linux" =~ "5.0" is true:
  if ($origFile[0] =~ $oldVersion)

The simple fix for this is getting pickier about what we match here. Better fix would be checking the actual data line's version/buildid, might not be worth the trouble though.

Updated

6 years ago
OS: Linux → All
Priority: -- → P3
Hardware: x86_64 → All
Whiteboard: [release-process-improvement][automation][updates]
No longer blocks: 627271
Blocks: 714371
(Assignee)

Updated

6 years ago
Assignee: nobody → bugspam.Callek
Priority: P3 → P2
(Assignee)

Comment 1

6 years ago
Created attachment 596489 [details] [diff] [review]
v1
Attachment #596489 - Flags: review?(bhearsum)
(Reporter)

Comment 2

6 years ago
Comment on attachment 596489 [details] [diff] [review]
v1

Review of attachment 596489 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, I think this works...
Attachment #596489 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 3

6 years ago
Comment on attachment 596489 [details] [diff] [review]
v1

http://hg.mozilla.org/build/tools/rev/5be9351f1e0b
Attachment #596489 - Flags: checked-in+
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.