Closed
Bug 669727
Opened 13 years ago
Closed 13 years ago
nsNodeUtils.cpp:518:10: warning: variable ‘isDeepDocumentClone’ set but not used [-Wunused-but-set-variable]
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
(Whiteboard: [build_warning][inbound])
Attachments
(1 file)
1.50 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
bug 564863 removed* the last usage of PRBool isDeepDocumentClone, triggering:
{
content/base/src/nsNodeUtils.cpp:518:10: warning: variable ‘isDeepDocumentClone’ set but not used [-Wunused-but-set-variable]
}
* http://hg.mozilla.org/mozilla-central/rev/ce0bc496b725#l13.12
Assignee | ||
Comment 1•13 years ago
|
||
Comment on attachment 544323 [details] [diff] [review]
fix (remove unused variable)
This is peterv's code. Patch obviously maintains current behavior, but I'm not sure if there's a bug here that should be fixed instead.
Attachment #544323 -
Flags: review?(jonas) → review?(peterv)
Assignee | ||
Comment 3•13 years ago
|
||
CC'ing smaug in case he has thoughts on comment 2, as he added the "isDeepDocumentClone" variable in the first place.
Assignee | ||
Updated•13 years ago
|
Attachment #544323 -
Attachment description: fix → fix (remove unused variable)
Comment 4•13 years ago
|
||
Bug 514487 added a test, so things should be working ok.
Updated•13 years ago
|
Attachment #544323 -
Flags: review?(peterv) → review+
Assignee | ||
Comment 5•13 years ago
|
||
OS: Linux → All
Hardware: x86_64 → All
Whiteboard: [build_warning] → [build_warning][inbound]
Comment 6•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•