nsNodeUtils.cpp:518:10: warning: variable ‘isDeepDocumentClone’ set but not used [-Wunused-but-set-variable]

RESOLVED FIXED in mozilla8

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks: 1 bug)

Trunk
mozilla8
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning][inbound])

Attachments

(1 attachment)

bug 564863 removed* the last usage of PRBool isDeepDocumentClone, triggering:
{
content/base/src/nsNodeUtils.cpp:518:10: warning: variable ‘isDeepDocumentClone’ set but not used [-Wunused-but-set-variable]
}

* http://hg.mozilla.org/mozilla-central/rev/ce0bc496b725#l13.12
Created attachment 544323 [details] [diff] [review]
fix (remove unused variable)
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #544323 - Flags: review?(jonas)
Comment on attachment 544323 [details] [diff] [review]
fix (remove unused variable)

This is peterv's code. Patch obviously maintains current behavior, but I'm not sure if there's a bug here that should be fixed instead.
Attachment #544323 - Flags: review?(jonas) → review?(peterv)
CC'ing smaug in case he has thoughts on comment 2, as he added the "isDeepDocumentClone" variable in the first place.
Attachment #544323 - Attachment description: fix → fix (remove unused variable)

Comment 4

6 years ago
Bug 514487 added a test, so things should be working ok.

Updated

6 years ago
Attachment #544323 - Flags: review?(peterv) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/a70a94b0eb87
OS: Linux → All
Hardware: x86_64 → All
Whiteboard: [build_warning] → [build_warning][inbound]
http://hg.mozilla.org/mozilla-central/rev/a70a94b0eb87
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.