Last Comment Bug 669810 - IndexedDB: IDBDatabase has an unused field mOnBlockedListener
: IndexedDB: IDBDatabase has an unused field mOnBlockedListener
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: DOM: IndexedDB (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla8
Assigned To: Ed Morley [:emorley]
:
:
Mentors:
Depends on:
Blocks: 423032
  Show dependency treegraph
 
Reported: 2011-07-06 19:17 PDT by Andrew McCreight [:mccr8]
Modified: 2012-03-22 12:50 PDT (History)
5 users (show)
khuey: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (2.98 KB, patch)
2011-08-05 02:28 PDT, Ed Morley [:emorley]
no flags Details | Diff | Splinter Review
Patch v2 (732 bytes, patch)
2011-08-05 07:35 PDT, Ed Morley [:emorley]
bent.mozilla: review+
Details | Diff | Splinter Review

Description Andrew McCreight [:mccr8] 2011-07-06 19:17:10 PDT
Doing cycle collector analysis, I noticed that the field mOnBlockedListener in IDBDatabase isn't in Traverse/Unlink, but bent said it can just be eliminated.

The field of this class is never accessed anywhere: http://mxr.mozilla.org/mozilla-central/search?string=mOnBlockedListener
Comment 1 Ed Morley [:emorley] 2011-08-05 02:28:22 PDT
Created attachment 550981 [details] [diff] [review]
Patch v1
Comment 2 Ed Morley [:emorley] 2011-08-05 07:35:31 PDT
Created attachment 551033 [details] [diff] [review]
Patch v2
Comment 3 Ed Morley [:emorley] 2011-08-05 13:33:08 PDT
http://dev.philringnalda.com/tbpl/?tree=Try&rev=9a167a6f6401
Comment 4 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-08-08 05:39:16 PDT
http://hg.mozilla.org/mozilla-central/rev/5de34e0967d5

Note You need to log in before you can comment on or make changes to this bug.