IndexedDB: IDBDatabase has an unused field mOnBlockedListener

RESOLVED FIXED in mozilla8

Status

()

Core
DOM: IndexedDB
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mccr8, Assigned: emorley)

Tracking

unspecified
mozilla8
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment, 1 obsolete attachment)

732 bytes, patch
Ben Turner (not reading bugmail, use the needinfo flag!)
: review+
Details | Diff | Splinter Review
(Reporter)

Description

6 years ago
Doing cycle collector analysis, I noticed that the field mOnBlockedListener in IDBDatabase isn't in Traverse/Unlink, but bent said it can just be eliminated.

The field of this class is never accessed anywhere: http://mxr.mozilla.org/mozilla-central/search?string=mOnBlockedListener
(Reporter)

Updated

6 years ago
Blocks: 423032
(Assignee)

Comment 1

6 years ago
Created attachment 550981 [details] [diff] [review]
Patch v1
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Attachment #550981 - Flags: review?(bent.mozilla)
(Assignee)

Comment 2

6 years ago
Created attachment 551033 [details] [diff] [review]
Patch v2
Attachment #550981 - Attachment is obsolete: true
Attachment #551033 - Flags: review?(bent.mozilla)
Attachment #550981 - Flags: review?(bent.mozilla)
Attachment #551033 - Flags: review?(bent.mozilla) → review+
(Assignee)

Comment 3

6 years ago
http://dev.philringnalda.com/tbpl/?tree=Try&rev=9a167a6f6401
Keywords: checkin-needed

Updated

6 years ago
Keywords: checkin-needed
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/5de34e0967d5
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
Component: DOM → DOM: IndexedDB
Target Milestone: mozilla8 → ---
Version: Trunk → unspecified
(Assignee)

Updated

6 years ago
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.