669905 - Searching in the new Downloads folder should limit the search to downloads

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Marco Bonardo [:mak]]

After discussing with Paolo, doesn't make sense for Library to search all history when Downloads is the current view, the search should be limited to downloads.

Comment 1

[skierpage]

These (great!) new features sound like additions to the Places UI, is Mozilla still using bug 437246 to track them?

Comment 2

[Marco Bonardo [:mak]]

(In reply to comment #1)
> These (great!) new features sound like additions to the Places UI, is
> Mozilla still using bug 437246 to track them?

no, that bug is pretty much useless, lost it long time ago.

Comment 3

[Marco Bonardo [:mak]]

Attachment: patch v1.0

doesn't have a test yet

Comment 4

[Marco Bonardo [:mak]]

Attachment: patch v1.1

fixed some glitches, and now has some testing too!

Comment 5

[Marco Bonardo [:mak]]

Attachment: patch v1.1 (8 lines of context)

uh, sorry I wrongly attached the 3-lines-of-context version

Comment 6

[Marco Bonardo [:mak]]

Mano, do you think you may complete this review before next merge (8 Aug). I'd like to have bug 564900 and this one in the FF8 timeframe.

Comment 7

[Marco Bonardo [:mak]]

fwiw, bug 564900 is practically ready to land

Comment 8

[Marco Bonardo [:mak]]

Comment on attachment 550495 [details] [diff] [review]
patch v1.1 (8 lines of context)

Dietrich, asking to you as well, per previous discussion.

Comment 9

[Ed Morley [:emorley]]

http://hg.mozilla.org/mozilla-central/rev/55377b8a385a