Searching in the new Downloads folder should limit the search to downloads

RESOLVED FIXED in Firefox 9

Status

()

Firefox
Bookmarks & History
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mak, Assigned: mak)

Tracking

Trunk
Firefox 9
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
After discussing with Paolo, doesn't make sense for Library to search all history when Downloads is the current view, the search should be limited to downloads.

Comment 1

6 years ago
These (great!) new features sound like additions to the Places UI, is Mozilla still using bug 437246 to track them?
(Assignee)

Comment 2

6 years ago
(In reply to comment #1)
> These (great!) new features sound like additions to the Places UI, is
> Mozilla still using bug 437246 to track them?

no, that bug is pretty much useless, lost it long time ago.
(Assignee)

Updated

6 years ago
Assignee: nobody → mak77
Status: NEW → ASSIGNED
(Assignee)

Comment 3

6 years ago
Created attachment 550400 [details] [diff] [review]
patch v1.0

doesn't have a test yet
(Assignee)

Comment 4

6 years ago
Created attachment 550492 [details] [diff] [review]
patch v1.1

fixed some glitches, and now has some testing too!
Attachment #550400 - Attachment is obsolete: true
Attachment #550492 - Flags: review?(dietrich)
(Assignee)

Comment 5

6 years ago
Created attachment 550495 [details] [diff] [review]
patch v1.1 (8 lines of context)

uh, sorry I wrongly attached the 3-lines-of-context version
Attachment #550492 - Attachment is obsolete: true
Attachment #550495 - Flags: review?(dietrich)
Attachment #550492 - Flags: review?(dietrich)
(Assignee)

Updated

6 years ago
Attachment #550495 - Flags: review?(dietrich) → review?(mano)
(Assignee)

Comment 6

6 years ago
Mano, do you think you may complete this review before next merge (8 Aug). I'd like to have bug 564900 and this one in the FF8 timeframe.
(Assignee)

Comment 7

6 years ago
fwiw, bug 564900 is practically ready to land
(Assignee)

Comment 8

6 years ago
Comment on attachment 550495 [details] [diff] [review]
patch v1.1 (8 lines of context)

Dietrich, asking to you as well, per previous discussion.
Attachment #550495 - Flags: review?(dietrich)
Attachment #550495 - Flags: review?(mano)
Attachment #550495 - Flags: review?(dietrich)
Attachment #550495 - Flags: review+
(Assignee)

Updated

6 years ago
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/55377b8a385a
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 9
(Assignee)

Updated

6 years ago
Blocks: 402231
You need to log in before you can comment on or make changes to this bug.