Closed Bug 669979 Opened 12 years ago Closed 12 years ago

When two-finger Scrolling with the trackpad (with momentum), pressing Ctrl while scrolling finishes causes page zoom if pixel scrolling is disabled

Categories

(Core :: DOM: Events, defect, P1)

Product:
Core
Component:
DOM: Events
Platform:
All
macOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla8
Tracking Flags:
Tracking Status
blocking2.0 --- final+

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

With the test change
2.81 KB, patch
masayuki
: review+
Details | Diff | Splinter Review 
+++ This bug was initially created as a clone of Bug #574663 +++

This is just like bug 574663, but first you need to flip "mousewheel.enable_pixel_scrolling" to false in about:config.  It looks like the patches in bug 574663 only modified the pixel-scrolling codepaths....

I finally figured out today that this is what causes sites to randomly zoom for me.
Assignee: nobody → bzbarsky
Component: Widget: Cocoa → DOM: Events
Priority: -- → P1
QA Contact: cocoa → events
Whiteboard: [need review]
You could extend content/events/test/test_bug574663.html to test this, for example by adding another flag to sendTouchpadScrollMotion that makes it send one line scroll with hasPixels = false instead of what it currently does.
Hmm.   Let me give that a shot!
Attachment #549815 - Flags: review?(Olli.Pettay) → review+
Verified that the changed test fails without the code change and passes with it.
Attachment #549820 - Flags: review?(masayuki)
Attachment #549815 - Attachment is obsolete: true
Attachment #549815 - Flags: review?(masayuki)
Comment on attachment 549820 [details] [diff] [review]
With the test change

r=me.

# Inside the if's parentheses are very messy, though... I'll sort out them ASAP.
Attachment #549820 - Flags: review?(masayuki) → review+
Whiteboard: [need review] → [need landing]
http://hg.mozilla.org/integration/mozilla-inbound/rev/908e0c628083
Flags: in-testsuite+
Whiteboard: [need landing]
Target Milestone: --- → mozilla8
http://hg.mozilla.org/mozilla-central/rev/908e0c628083
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.