670003 - [OS/2] update Yarr files

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Walter Meinl]

Attachment: v1 update YARR OS/2 files

Dave has made an initial patch to update Yarr for OS/2

Comment 1

[David Mandelin [:dmandelin]]

Is the patch ready for review?

Comment 2

[Dave Yeo]

(In reply to comment #1)
> Is the patch ready for review?

Testing an updated patch, will ask you for review after testing

Comment 3

[Dave Yeo]

Attachment: Update Yarr to work on OS/2

Comment 4

[Dave Yeo]

Attachment: Update Yarr to work on OS/2

After some feedback from Rich patch updated with better commit and decommit plus a simplification of protection()

Comment 5

[David Mandelin [:dmandelin]]

Comment on attachment 545089 [details] [diff] [review]
Update Yarr to work on OS/2

Review of attachment 545089 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/yarr/PageBlock.cpp
@@ +58,5 @@
> +{
> +    return getpagesize();
> +}
> +
> +#elif WTF_OS_OS2

One question: any reason not to just use

  #if (WTF_OS_UNIX && !WTF_OS_SYMBIAN) || WTF_OS_OS2

above?

Comment 6

[Dave Yeo]

Attachment: Update Yarr to work on OS/2

(In reply to comment #5)
> Comment on attachment 545089 [details] [diff] [review] [review]
> Update Yarr to work on OS/2
> 
> Review of attachment 545089 [details] [diff] [review] [review]:
> -----------------------------------------------------------------
> 
> ::: js/src/yarr/PageBlock.cpp
> @@ +58,5 @@
> > +{
> > +    return getpagesize();
> > +}
> > +
> > +#elif WTF_OS_OS2
> 
> One question: any reason not to just use
> 
>   #if (WTF_OS_UNIX && !WTF_OS_SYMBIAN) || WTF_OS_OS2
> 
> above?

I meant to fix this and forgot. Updated patch attached

Comment 7

[David Mandelin [:dmandelin]]

Comment on attachment 545319 [details] [diff] [review]
Update Yarr to work on OS/2

Review of attachment 545319 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 8

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/e9245c104f52

Comment 9

[Daniel Holbert [:dholbert]]

(Technically, bugs aren't FIXED until their patches make it into mozilla-central.  That should happen for this bug in the next day or so, at the next merge from mozilla-inbound. Whoever merges mozilla-inbound to mozilla-central will resolve this bug.)

Comment 10

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/e9245c104f52