The default bug view has changed. See this FAQ.

[OS/2] update Yarr files

RESOLVED FIXED in mozilla8

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Walter Meinl, Assigned: Dave Yeo)

Tracking

Trunk
mozilla8
x86
OS/2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: tracemonkey)

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

6 years ago
Created attachment 544617 [details] [diff] [review]
v1 update YARR OS/2 files

Dave has made an initial patch to update Yarr for OS/2
(Reporter)

Updated

6 years ago
Attachment #544617 - Attachment is patch: true
Attachment #544617 - Attachment mime type: message/rfc822 → text/plain
(Reporter)

Updated

6 years ago
Assignee: general → daveryeo
Status: NEW → ASSIGNED
Is the patch ready for review?
(Assignee)

Comment 2

6 years ago
(In reply to comment #1)
> Is the patch ready for review?

Testing an updated patch, will ask you for review after testing
Blocks: 625600
(Assignee)

Comment 3

6 years ago
Created attachment 545007 [details] [diff] [review]
Update Yarr to work on OS/2
Attachment #544617 - Attachment is obsolete: true
Attachment #545007 - Flags: review?(dmandelin)
(Assignee)

Comment 4

6 years ago
Created attachment 545089 [details] [diff] [review]
Update Yarr to work on OS/2

After some feedback from Rich patch updated with better commit and decommit plus a simplification of protection()
Attachment #545007 - Attachment is obsolete: true
Attachment #545089 - Flags: review?(dmandelin)
Attachment #545007 - Flags: review?(dmandelin)
Comment on attachment 545089 [details] [diff] [review]
Update Yarr to work on OS/2

Review of attachment 545089 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/yarr/PageBlock.cpp
@@ +58,5 @@
> +{
> +    return getpagesize();
> +}
> +
> +#elif WTF_OS_OS2

One question: any reason not to just use

  #if (WTF_OS_UNIX && !WTF_OS_SYMBIAN) || WTF_OS_OS2

above?
(Assignee)

Comment 6

6 years ago
Created attachment 545319 [details] [diff] [review]
Update Yarr to work on OS/2

(In reply to comment #5)
> Comment on attachment 545089 [details] [diff] [review] [review]
> Update Yarr to work on OS/2
> 
> Review of attachment 545089 [details] [diff] [review] [review]:
> -----------------------------------------------------------------
> 
> ::: js/src/yarr/PageBlock.cpp
> @@ +58,5 @@
> > +{
> > +    return getpagesize();
> > +}
> > +
> > +#elif WTF_OS_OS2
> 
> One question: any reason not to just use
> 
>   #if (WTF_OS_UNIX && !WTF_OS_SYMBIAN) || WTF_OS_OS2
> 
> above?

I meant to fix this and forgot. Updated patch attached
Attachment #545089 - Attachment is obsolete: true
Attachment #545319 - Flags: review?(dmandelin)
Attachment #545089 - Flags: review?(dmandelin)
Comment on attachment 545319 [details] [diff] [review]
Update Yarr to work on OS/2

Review of attachment 545319 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #545319 - Flags: review?(dmandelin) → review+
(Reporter)

Updated

6 years ago
Keywords: checkin-needed
Whiteboard: tracemonkey
http://hg.mozilla.org/integration/mozilla-inbound/rev/e9245c104f52
Keywords: checkin-needed
Whiteboard: tracemonkey → tracemonkey [inbound]
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Technically, bugs aren't FIXED until their patches make it into mozilla-central.  That should happen for this bug in the next day or so, at the next merge from mozilla-inbound. Whoever merges mozilla-inbound to mozilla-central will resolve this bug.)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → ASSIGNED
http://hg.mozilla.org/mozilla-central/rev/e9245c104f52
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
Whiteboard: tracemonkey [inbound] → tracemonkey
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.