The default bug view has changed. See this FAQ.

Make DecodeToTarget sample accurate for audio

RESOLVED FIXED

Status

()

Core
Audio/Video
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox8 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Our seeks use nsBuiltinDecoderReader::DecodeToTarget() to decode up to the seek target after the main seek returns. This pumps the decode until the decode produces a VideoData and/or SoundData which contains the seek target. But for audio we'll begin playback at the start of the SoundData, not at the actual seek target. There could be an unknown amount of sound data before the seek target, reducing the accuracy of our seek.
(Assignee)

Comment 1

6 years ago
Created attachment 544668 [details] [diff] [review]
Patch v1: Prune unnecessary leading audio samples
Attachment #544668 - Flags: review?(kinetik)
Attachment #544668 - Flags: review?(kinetik) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/14750ef487b5
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/14750ef487b5
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
(Assignee)

Updated

6 years ago
status-firefox8: --- → fixed
Whiteboard: [inbound]
Target Milestone: mozilla8 → ---
(Assignee)

Updated

6 years ago
Depends on: 670726
(Assignee)

Updated

6 years ago
Depends on: 675045

Updated

6 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.