670056 - no context menu in http auth dialog

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Kevin Brosnan [Ex-Mozilla]]

1. open a page using http auth
2. long click to bring up the context menu
3. no such dialog appears

expected context menu on long click

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Are menus lower in the z-order than dialogs?

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch

Quick fix to import dialogs above the context menu (not the menulist menu).

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Patch

Whoops. Better fix.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 547133 [details] [diff] [review]
Patch

The reason we import after "menulist-container" is for select prompts, which need the menulist UI.

If we changed the UI of the select dialog to use a richlistbox directly and not need the menulist UX.

We could also move the "context-container" to after the menulist-container, but that might have fallout too.

Comment 5

[Wesley Johnston (:wesj)]

I'm confused. This will change our xul so that we have (vastly oversimplified and only when a dialog is open):

<stack>
  <dialog/>
  <contextmenu/>
  <menulist/>
</stack>

So both menulists (for select prompts) and context menus (for pasting into a textbox) will show on top of the dialog.

We could do something a lot more complex (i.e. move things around when pushDialog, pushPopup are called to ensure the new popup is always on top). That's also prone to introducing errors, but we have a long stretch right now, and I could hide it behind a pref while we tested.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 547133 [details] [diff] [review]
Patch

No, I was confused. Yes, this should work better.

Comment 7

[Wesley Johnston (:wesj)]

inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/31e6d1136b01

Comment 8

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/31e6d1136b01

Comment 9

[Andreea Pod]

I don't know if I understood it right but trying to reproduce this I installed nightly build from 07/07 when the bug was filed. I went to yahoo mail log in page and long tap in the text fields opened the context menu. 

Can you give more details so I can verify this?

Comment 10

[Carla Nadastean]

Retested bug with:
Build id : Mozilla/5.0 (Android;Linux armv7l; rv:9.0a1)Gecko/20110927
Firefox/9.0a1 Fennec /9.0a1
Device: Motorola DROID 2
OS: Android 2.3

I visited a page using http auth: https://fisheye.last.fm/

Context menu is displayed properly for both user name and password fields(is no longer displayed in background as in 07/07 build).

Verifying bug.