stop caching plugin instances

RESOLVED FIXED in mozilla8

Status

()

Core
Plug-ins
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Josh Aas, Assigned: Josh Aas)

Tracking

Trunk
mozilla8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
I don't think we ever want to restart a plugin instance so we can stop caching them entirely and remove code that looks for an old stopped instance to re-use when instantiating.

I'm not sure we want to support NPPVpluginKeepLibraryInMemory either. Right now that marks an instance for caching, which effectively prevents its plugin from ever unloading since an instance will remain indefinitely. This is a silly way to implement it, a better way would be to just mark the plugin as do-not-unload when this is set on any instance. However, since we don't unload plugins by default anyway this isn't really an issue.
(Assignee)

Comment 1

6 years ago
Created attachment 544733 [details] [diff] [review]
fix v1.0
Attachment #544733 - Flags: review?(jst)
Comment on attachment 544733 [details] [diff] [review]
fix v1.0

Yeah, this never seemed like a good idea to me either. r=jst
Attachment #544733 - Flags: review?(jst) → review+
(Assignee)

Comment 3

6 years ago
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/b4725ef65601
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Does this fix bu 659348?

Updated

6 years ago
Depends on: 700835
If I'm reading 
  https://wiki.mozilla.org/RapidRelease#Merge_and_Release_Dates
correctly this fix was first in Firefox 8.
Target Milestone: --- → mozilla8
Yes.  And this is confirmed by the names of the 2011-07-08 and 2011-07-09 mozilla-central nightlies, which claim to be "8.0a1".
Depends on: 705931
No longer depends on: 705931
You need to log in before you can comment on or make changes to this bug.