Closed
Bug 670091
Opened 14 years ago
Closed 14 years ago
Undefined reference to js_myfmod on mingw-w64
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: jacek, Assigned: jacek)
References
Details
Attachments
(1 file)
|
759 bytes,
patch
|
m_kato
:
review+
|
Details | Diff | Splinter Review |
Bug 635617 introduced my_fmod as a workaround for MSC compiler, but #ifdefs check only version of MSC, don't check if we're on MSC.
Attachment #544753 -
Flags: review?(m_kato)
|
||
Comment 1•14 years ago
|
||
(In reply to comment #0)
> Created attachment 544753 [details] [diff] [review] [review]
> fix v1.0
>
> Bug 635617 introduced my_fmod as a workaround for MSC compiler, but #ifdefs
> check only version of MSC, don't check if we're on MSC.
Jacek, does mingw64 has _M_X64?
|
Assignee | |
Comment 2•14 years ago
|
||
(In reply to comment #1)
> (In reply to comment #0)
> > Created attachment 544753 [details] [diff] [review] [review] [review]
> > fix v1.0
> >
> > Bug 635617 introduced my_fmod as a workaround for MSC compiler, but #ifdefs
> > check only version of MSC, don't check if we're on MSC.
>
> Jacek, does mingw64 has _M_X64?
Yes, it does. mingw-w64 generally tries to be compatible with MSC about such things.
|
|
||
Comment 3•14 years ago
|
||
Comment on attachment 544753 [details] [diff] [review]
fix v1.0
Review of attachment 544753 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #544753 -
Flags: review?(m_kato) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Thanks for review, pushed to m-i:
http://hg.mozilla.org/integration/mozilla-inbound/rev/c620827546bb
Whiteboard: [inbound]
|
||
Comment 5•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•