Note: There are a few cases of duplicates in user autocompletion which are being worked on.

gfx/2d fails to compile on mingw

RESOLVED FIXED in mozilla9

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla9
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 544754 [details] [diff] [review]
fix v1.0

There are two problems:

- Macros __in and __out are not supported by mingw, because they conflict with GCC-provided headers. They are mostly no-op anyways, so just removing them should be fine.

- There are wrong cases in includes, which causes problems when cross compiling on case-sensitive OSes.
Attachment #544754 - Flags: review?
(Assignee)

Updated

6 years ago
Attachment #544754 - Flags: review? → review?(bas.schouten)
Comment on attachment 544754 [details] [diff] [review]
fix v1.0

The lower/uppercase is actually interesting, as on different SDKs they seem to be shipped with different casing.
(Assignee)

Comment 2

6 years ago
It doesn't matter for Microsoft-provided SDKs. They work only on Windows, which is case-insensitive. Also they change quite often from version to version, so it's impossible to be compatible with them. mingw, however, always uses lower-cases.
(Assignee)

Comment 3

6 years ago
Bas, ping
Comment on attachment 544754 [details] [diff] [review]
fix v1.0

Review of attachment 544754 [details] [diff] [review]:
-----------------------------------------------------------------

If MinGW always uses lowercases that's fine :). Sorry for the delay, I missed this bug.

Just out of curiosity, now that Visual Studio Express is free, why would anyone -want- to build with MinGW?
Attachment #544754 - Flags: review?(bas.schouten) → review+
(Assignee)

Comment 5

6 years ago
(In reply to Bas Schouten (:bas) from comment #4)

Thanks for review.

> Just out of curiosity, now that Visual Studio Express is free, why would
> anyone -want- to build with MinGW?

Well, there would be a few reasons like ability to cross compile from Linux or just free software ideology (it's possible to build Windows Firefox without running single line of closed source code). My main reason is that I'm working Wine (www.winehq.org) and we use Gecko for out MSHTML implementation. To make it a proper package, we need to be able to build Gecko on Linux.
(Assignee)

Comment 6

6 years ago
(In reply to Jacek Caban from comment #5)
> To make it a proper package, we need to be able to build Gecko on Linux.

I meant Windows Gecko build here (built on Linux so that distros can package it correctly).
(Assignee)

Comment 7

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/a5a018eb7e54
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/a5a018eb7e54
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.