670093 - gfx/2d fails to compile on mingw

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jacek Caban]

Attachment: fix v1.0

There are two problems:

- Macros __in and __out are not supported by mingw, because they conflict with GCC-provided headers. They are mostly no-op anyways, so just removing them should be fine.

- There are wrong cases in includes, which causes problems when cross compiling on case-sensitive OSes.

Comment 1

[Bas Schouten (:bas.schouten)]

Comment on attachment 544754 [details] [diff] [review]
fix v1.0

The lower/uppercase is actually interesting, as on different SDKs they seem to be shipped with different casing.

Comment 2

[Jacek Caban]

It doesn't matter for Microsoft-provided SDKs. They work only on Windows, which is case-insensitive. Also they change quite often from version to version, so it's impossible to be compatible with them. mingw, however, always uses lower-cases.

Comment 3

[Jacek Caban]

Bas, ping

Comment 4

[Bas Schouten (:bas.schouten)]

Comment on attachment 544754 [details] [diff] [review]
fix v1.0

Review of attachment 544754 [details] [diff] [review]:
-----------------------------------------------------------------

If MinGW always uses lowercases that's fine :). Sorry for the delay, I missed this bug.

Just out of curiosity, now that Visual Studio Express is free, why would anyone -want- to build with MinGW?

Comment 5

[Jacek Caban]

(In reply to Bas Schouten (:bas) from comment #4)

Thanks for review.

> Just out of curiosity, now that Visual Studio Express is free, why would
> anyone -want- to build with MinGW?

Well, there would be a few reasons like ability to cross compile from Linux or just free software ideology (it's possible to build Windows Firefox without running single line of closed source code). My main reason is that I'm working Wine (www.winehq.org) and we use Gecko for out MSHTML implementation. To make it a proper package, we need to be able to build Gecko on Linux.

Comment 6

[Jacek Caban]

(In reply to Jacek Caban from comment #5)
> To make it a proper package, we need to be able to build Gecko on Linux.

I meant Windows Gecko build here (built on Linux so that distros can package it correctly).

Comment 7

[Jacek Caban]

http://hg.mozilla.org/integration/mozilla-inbound/rev/a5a018eb7e54

Comment 8

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/a5a018eb7e54