The default bug view has changed. See this FAQ.

JSOPTION_UNROOTED_GLOBAL is lost in ContextHolder::ContextHolder

RESOLVED FIXED in mozilla8

Status

()

Core
XPConnect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: billm, Assigned: billm)

Tracking

unspecified
mozilla8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 544871 [details] [diff] [review]
fix

Copying this from bug 585221...

I'm getting an assertion here:

void XPCJSRuntime::TraceXPConnectRoots(JSTracer *trc)
{ ...
        JS_ASSERT(acx->hasRunOption(JSOPTION_UNROOTED_GLOBAL));
}

The place where the option gets unset is here:
ContextHolder::ContextHolder(JSContext *aOuterCx, JSObject *aSandbox)
{ ...
        JS_SetOptions(mJSContext,
                      JSOPTION_DONT_REPORT_UNCAUGHT |
                      JSOPTION_PRIVATE_IS_NSISUPPORTS);
}

I made a patch that ORs in the existing options (which currently are just the unrooted global option).
Attachment #544871 - Flags: review?(mrbkap)

Comment 1

6 years ago
This is great. I have been looking for this bug forever.

Updated

6 years ago
Attachment #544871 - Flags: review?(mrbkap) → review+
(Assignee)

Updated

6 years ago
Whiteboard: [inbound]
Backed out of inbound because of build bustage.
Whiteboard: [inbound]
(Assignee)

Updated

6 years ago
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/0737efca777e
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.