670226 - "ASSERTION: negative length" with rtl, pre-line, :first-letter{float}

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: negative length: 'GetContentEnd() - mContentOffset >= 0', file nsTextFrame.h, line 360

Comment 1

[Simon Montagu :smontagu]

Attachment: Patch

This is caused by a bug that I noticed by code inspection while working on bug 668941 and was going to file as soon as I had worked out a reftest for it. It's a regression from 665837: when we break off traversing frames because the last sibling is before the newline, we shouldn't be calling ResolveParagraph.

Comment 2

[Simon Montagu :smontagu]

Attachment: Tests

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 545211 [details] [diff] [review]
Patch

Review of attachment 545211 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 545212 [details] [diff] [review]
Tests

Review of attachment 545212 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 5

[Simon Montagu :smontagu]

http://hg.mozilla.org/mozilla-central/rev/e899fed03195
http://hg.mozilla.org/mozilla-central/rev/c847d67a09f8

Comment 6

[Simon Montagu :smontagu]

Comment on attachment 545211 [details] [diff] [review]
Patch

This fixes a regression from bug 665837 which was checked in on Aurora, so the fix should go on Aurora too. Beta is unaffected.

Comment 7

[Simon Montagu :smontagu]

http://hg.mozilla.org/releases/mozilla-aurora/rev/579cbf7a9add
http://hg.mozilla.org/releases/mozilla-aurora/rev/433cd269be19

Comment 8

[u279076]

qa- as no QA fix verification needed