Closed Bug 670226 Opened 8 years ago Closed 8 years ago

"ASSERTION: negative length" with rtl, pre-line, :first-letter{float}

Categories

(Core :: Layout: Text and Fonts, defect)

x86_64
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
firefox7 --- fixed

People

(Reporter: jruderman, Assigned: smontagu)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, regression, testcase, Whiteboard: [qa-])

Attachments

(3 files)

Attached file testcase
###!!! ASSERTION: negative length: 'GetContentEnd() - mContentOffset >= 0', file nsTextFrame.h, line 360
Attached patch PatchSplinter Review
This is caused by a bug that I noticed by code inspection while working on bug 668941 and was going to file as soon as I had worked out a reftest for it. It's a regression from 665837: when we break off traversing frames because the last sibling is before the newline, we shouldn't be calling ResolveParagraph.
Attachment #545211 - Flags: review?(roc)
Attached patch TestsSplinter Review
Assignee: nobody → smontagu
Attachment #545212 - Flags: review?(roc)
Comment on attachment 545211 [details] [diff] [review]
Patch

Review of attachment 545211 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #545211 - Flags: review?(roc) → review+
Comment on attachment 545212 [details] [diff] [review]
Tests

Review of attachment 545212 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #545212 - Flags: review?(roc) → review+
http://hg.mozilla.org/mozilla-central/rev/e899fed03195
http://hg.mozilla.org/mozilla-central/rev/c847d67a09f8
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Blocks: 665837
Comment on attachment 545211 [details] [diff] [review]
Patch

This fixes a regression from bug 665837 which was checked in on Aurora, so the fix should go on Aurora too. Beta is unaffected.
Attachment #545211 - Flags: approval-mozilla-aurora?
Attachment #545211 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
qa- as no QA fix verification needed
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.