The default bug view has changed. See this FAQ.

"ASSERTION: negative length" with rtl, pre-line, :first-letter{float}

RESOLVED FIXED

Status

()

Core
Layout: Text
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jesse Ruderman, Assigned: smontagu)

Tracking

(Blocks: 1 bug, {assertion, regression, testcase})

Trunk
x86_64
Mac OS X
assertion, regression, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox7 fixed)

Details

(Whiteboard: [qa-])

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
Created attachment 544884 [details]
testcase

###!!! ASSERTION: negative length: 'GetContentEnd() - mContentOffset >= 0', file nsTextFrame.h, line 360
(Assignee)

Comment 1

6 years ago
Created attachment 545211 [details] [diff] [review]
Patch

This is caused by a bug that I noticed by code inspection while working on bug 668941 and was going to file as soon as I had worked out a reftest for it. It's a regression from 665837: when we break off traversing frames because the last sibling is before the newline, we shouldn't be calling ResolveParagraph.
Attachment #545211 - Flags: review?(roc)
(Assignee)

Comment 2

6 years ago
Created attachment 545212 [details] [diff] [review]
Tests
Assignee: nobody → smontagu
Attachment #545212 - Flags: review?(roc)
Comment on attachment 545211 [details] [diff] [review]
Patch

Review of attachment 545211 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #545211 - Flags: review?(roc) → review+
Comment on attachment 545212 [details] [diff] [review]
Tests

Review of attachment 545212 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #545212 - Flags: review?(roc) → review+
(Assignee)

Comment 5

6 years ago
http://hg.mozilla.org/mozilla-central/rev/e899fed03195
http://hg.mozilla.org/mozilla-central/rev/c847d67a09f8
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Blocks: 665837
(Assignee)

Comment 6

6 years ago
Comment on attachment 545211 [details] [diff] [review]
Patch

This fixes a regression from bug 665837 which was checked in on Aurora, so the fix should go on Aurora too. Beta is unaffected.
Attachment #545211 - Flags: approval-mozilla-aurora?
Keywords: regression

Updated

6 years ago
Attachment #545211 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 7

6 years ago
http://hg.mozilla.org/releases/mozilla-aurora/rev/579cbf7a9add
http://hg.mozilla.org/releases/mozilla-aurora/rev/433cd269be19
status-firefox7: --- → fixed
qa- as no QA fix verification needed
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.