670338 - Add double overload to NSToIntRound to stop build warnings

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Ed Morley [:emorley]]

+++ This bug was initially created as a clone of Bug #670111 +++

Bug 447838 is trying to stop the build warnings in nsTextFrameThebes.cpp, many of which are along the lines of:
> warning C4244: 'argument' : conversion from 'gfxFloat' to 'float', possible loss of data

To save clarity reducing changes like:
-          TabWidth(i - startOffset, nextTab - mOffsetFromBlockOriginForTabs));
+          TabWidth(i - startOffset, 
+                   NSToIntRound(float(nextTab - mOffsetFromBlockOriginForTabs))));

Roc suggested that I add a double overload to NSToIntRound.

Hopefully this will reduce the number of build warnings in files other than nsTextFrameThebes.cpp as well.

Comment 1

[Ed Morley [:emorley]]

Attachment: Patch v1

Double overload for NSToIntRound, broken out from bug 447838.

Was going to include this in bug 670111 along with the NSToCoord* changes, but that's already reviewed and checkin-needed, so thought it would just be easier to deal with separately.

Comment 2

[Ed Morley [:emorley]]

http://dev.philringnalda.com/tbpl/?tree=Try&rev=24df92bc84bb

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 544978 [details] [diff] [review]
Patch v1

Review of attachment 544978 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 4

[Ed Morley [:emorley]]

Passed try (comment 2).

Comment 5

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/ed3036facfb2

Comment 6

[Mounir Lamouri (:mounir)]

Merged:
http://hg.mozilla.org/mozilla-central/rev/ed3036facfb2

Comment 7

[(no longer active)]

I've backed this out from inbound to see if it affects the frequency of bug 629196: <http://hg.mozilla.org/integration/mozilla-inbound/rev/af960bd72863>

Comment 8

[Joe Drew (not getting mail)]

And this backout was merged to m-c: http://hg.mozilla.org/mozilla-central/rev/af960bd72863

Comment 9

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/a82beacfb5e3