Last Comment Bug 670487 - Fixing rl_ttyset prototype in js/src/editline.
: Fixing rl_ttyset prototype in js/src/editline.
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All Other
: -- normal (vote)
: mozilla8
Assigned To: Cyril Roelandt
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-09 19:56 PDT by Cyril Roelandt
Modified: 2011-07-13 09:00 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix the prototype of rl_ttyset(). (394 bytes, patch)
2011-07-09 19:56 PDT, Cyril Roelandt
brendan: review+
Details | Diff | Splinter Review

Description Cyril Roelandt 2011-07-09 19:56:11 PDT
Created attachment 545043 [details] [diff] [review]
Fix the prototype of rl_ttyset().

User Agent: Mozilla/5.0 (X11; Linux i686; rv:5.0) Gecko/20100101 Firefox/5.0
Build ID: 2011061500

Steps to reproduce:

I compiled the trunk version of Firefox.


Actual results:

It compiles fine and Firefox works perfectly, but the compiler (GCC 4.5.1) prints out these warnings :

mozilla/js/src/editline/editline.c:1026:5: warning: call to function ‘rl_ttyset’ without a real prototype
mozilla/js/src/editline/editline.h:118:13: note: ‘rl_ttyset’ was declared here
mozilla/js/src/editline/editline.c:1037:5: warning: call to function ‘rl_ttyset’ without a real prototype
mozilla/js/src/editline/editline.h:118:13: note: ‘rl_ttyset’ was declared here


Expected results:

These warnings should not appear. Though one should not really worry about them, they pollute the compiler's output. The attached patch should fix this.
Comment 1 Brendan Eich [:brendan] 2011-07-11 18:36:21 PDT
Comment on attachment 545043 [details] [diff] [review]
Fix the prototype of rl_ttyset().

Thanks for the patch -- wow, this code is old.

Ask around on irc.mozilla.org #jsapi for help landing this, please.

/be

Note You need to log in before you can comment on or make changes to this bug.