Closed Bug 670487 Opened 8 years ago Closed 8 years ago

Fixing rl_ttyset prototype in js/src/editline.

Categories

(Core :: JavaScript Engine, defect)

All
Other
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: tipecaml, Assigned: tipecaml)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux i686; rv:5.0) Gecko/20100101 Firefox/5.0
Build ID: 2011061500

Steps to reproduce:

I compiled the trunk version of Firefox.


Actual results:

It compiles fine and Firefox works perfectly, but the compiler (GCC 4.5.1) prints out these warnings :

mozilla/js/src/editline/editline.c:1026:5: warning: call to function ‘rl_ttyset’ without a real prototype
mozilla/js/src/editline/editline.h:118:13: note: ‘rl_ttyset’ was declared here
mozilla/js/src/editline/editline.c:1037:5: warning: call to function ‘rl_ttyset’ without a real prototype
mozilla/js/src/editline/editline.h:118:13: note: ‘rl_ttyset’ was declared here


Expected results:

These warnings should not appear. Though one should not really worry about them, they pollute the compiler's output. The attached patch should fix this.
Attachment #545043 - Flags: review?(brendan)
Comment on attachment 545043 [details] [diff] [review]
Fix the prototype of rl_ttyset().

Thanks for the patch -- wow, this code is old.

Ask around on irc.mozilla.org #jsapi for help landing this, please.

/be
Attachment #545043 - Flags: review?(brendan) → review+
Keywords: checkin-needed
Assignee: nobody → tipecaml
http://hg.mozilla.org/mozilla-central/rev/9bc361598877
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago
Component: General → JavaScript Engine
Keywords: checkin-needed
Product: Firefox → Core
QA Contact: general → general
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.