670686 - jscrashreport.cpp fails to compile on mingw

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jacek Caban]

Attachment: fix v1.0

It's mostly due to using MS-style inline assembly. I could add ifdefed GCC assembly, but I think it's cleaner to use the existing solution for win64 and call RtlCaptureContext.

I've also changed case in windows.h include to fix cross compiling on case sensitive OSes.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Thanks for the patch. Unfortunately, I just found out on #developers that we still nominally support Windows 2000, where RtlCaptureContext is unavailable. Is there some other way to do this?

Comment 2

[Jacek Caban]

Attachment: fix with inline GCC assembly

Comment 3

[Jacek Caban]

Attachment: fix without support for win2k in mingw builds

Comment 4

[Jacek Caban]

Thanks for quick review. I've attached two versions of the fix that will keep support for win2k. The first version is just a port of existing assembly code to GCC. The second version is my previous approach, ifdefed so that MSC builds will still use assembly code. I think it's fine to not support win2k in mingw builds (I'd expect it to be already broken). Also this way, once we'll drop win2k support, we can just remove _MSC_VER ifdef and use the new code for MSC as well. I will the choice for you.

Comment 5

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 545214 [details] [diff] [review]
fix without support for win2k in mingw builds

Review of attachment 545214 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks again. I like this one better.

Comment 6

[Jacek Caban]

Pushed to m-i:

http://hg.mozilla.org/integration/mozilla-inbound/rev/126abe6c099a

Comment 7

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/126abe6c099a