670750 - Move appropriate entites from navigator.dtd to navigatorOverlay.dtd which are only used in navigatorOverlay.xul

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Ian Neal]

From bug 669291 comment 3
>+<!ENTITY % navigatorOverlayDTD SYSTEM "chrome://navigator/locale/navigatorOverlay.dtd">
>+%navigatorOverlayDTD;
[I wonder whether we should start moving stuff here from navigator.dtd]

Comment 1

[Ian Neal]

Attachment: Move appropriate entities to navigatorOverlay.dtd [Checked in: Comment 5]

This patch:
* Moves entities that only used in navigatorOverlay.xul from navigator.dtd to navigatorOverlay.dtd

Comment 2

[[e-mail]]

Comment on attachment 545350 [details] [diff] [review]
Move appropriate entities to navigatorOverlay.dtd [Checked in: Comment 5]

> <!ENTITY editPageCmd.label "Edit Page">
> <!ENTITY editPageCmd.accesskey "E">
> <!ENTITY editPageCmd.commandkey "e">
I don't see where this is used in navigator.xul?

> <!ENTITY printPreviewCmd.label "Print Preview">
> <!ENTITY printPreviewCmd.accesskey "v">
> <!ENTITY printCmd.label "Printâ¦">
> <!ENTITY printCmd.accesskey "p">
> <!ENTITY printCmd.commandkey "p">
Are these the only shared entities?

Comment 3

[Ian Neal]

(In reply to comment #2)
> Comment on attachment 545350 [details] [diff] [review] [review]
> Move appropriate entities to navigatorOverlay.dtd
> 
> > <!ENTITY editPageCmd.label "Edit Page">
> > <!ENTITY editPageCmd.accesskey "E">
> > <!ENTITY editPageCmd.commandkey "e">
> I don't see where this is used in navigator.xul?
They are used in both navigatorOverlay.xul and viewSourceOverlay.xul so at the moment I have left them in navigator.dtd
> 
> > <!ENTITY printPreviewCmd.label "Print Preview">
> > <!ENTITY printPreviewCmd.accesskey "v">
> > <!ENTITY printCmd.label "Printâ¦">
> > <!ENTITY printCmd.accesskey "p">
> > <!ENTITY printCmd.commandkey "p">
> Are these the only shared entities?

I think so, but I'll be looking at doing something with these in a follow-up patch.

Comment 4

[[e-mail]]

Comment on attachment 545350 [details] [diff] [review]
Move appropriate entities to navigatorOverlay.dtd [Checked in: Comment 5]

Fair enough: if you've got plans for those, let's get things moving!

Comment 5

[Ian Neal]

Comment on attachment 545350 [details] [diff] [review]
Move appropriate entities to navigatorOverlay.dtd [Checked in: Comment 5]

http://hg.mozilla.org/comm-central/rev/c4d0fb70b99a