Closed Bug 670750 Opened 8 years ago Closed 8 years ago

Move appropriate entites from navigator.dtd to navigatorOverlay.dtd which are only used in navigatorOverlay.xul

Categories

(SeaMonkey :: UI Design, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.5

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

Details

Attachments

(1 file)

From bug 669291 comment 3
>+<!ENTITY % navigatorOverlayDTD SYSTEM "chrome://navigator/locale/navigatorOverlay.dtd">
>+%navigatorOverlayDTD;
[I wonder whether we should start moving stuff here from navigator.dtd]
OS: Linux → All
Hardware: x86_64 → All
This patch:
* Moves entities that only used in navigatorOverlay.xul from navigator.dtd to navigatorOverlay.dtd
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Attachment #545350 - Flags: review?(neil)
Comment on attachment 545350 [details] [diff] [review]
Move appropriate entities to navigatorOverlay.dtd [Checked in: Comment 5]

> <!ENTITY editPageCmd.label "Edit Page">
> <!ENTITY editPageCmd.accesskey "E">
> <!ENTITY editPageCmd.commandkey "e">
I don't see where this is used in navigator.xul?

> <!ENTITY printPreviewCmd.label "Print Preview">
> <!ENTITY printPreviewCmd.accesskey "v">
> <!ENTITY printCmd.label "Print…">
> <!ENTITY printCmd.accesskey "p">
> <!ENTITY printCmd.commandkey "p">
Are these the only shared entities?
(In reply to comment #2)
> Comment on attachment 545350 [details] [diff] [review] [review]
> Move appropriate entities to navigatorOverlay.dtd
> 
> > <!ENTITY editPageCmd.label "Edit Page">
> > <!ENTITY editPageCmd.accesskey "E">
> > <!ENTITY editPageCmd.commandkey "e">
> I don't see where this is used in navigator.xul?
They are used in both navigatorOverlay.xul and viewSourceOverlay.xul so at the moment I have left them in navigator.dtd
> 
> > <!ENTITY printPreviewCmd.label "Print Preview">
> > <!ENTITY printPreviewCmd.accesskey "v">
> > <!ENTITY printCmd.label "Print…">
> > <!ENTITY printCmd.accesskey "p">
> > <!ENTITY printCmd.commandkey "p">
> Are these the only shared entities?

I think so, but I'll be looking at doing something with these in a follow-up patch.
Comment on attachment 545350 [details] [diff] [review]
Move appropriate entities to navigatorOverlay.dtd [Checked in: Comment 5]

Fair enough: if you've got plans for those, let's get things moving!
Attachment #545350 - Flags: review?(neil) → review+
Comment on attachment 545350 [details] [diff] [review]
Move appropriate entities to navigatorOverlay.dtd [Checked in: Comment 5]

http://hg.mozilla.org/comm-central/rev/c4d0fb70b99a
Attachment #545350 - Attachment description: Move appropriate entities to navigatorOverlay.dtd → Move appropriate entities to navigatorOverlay.dtd [Checked in: Comment 5]
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.5
You need to log in before you can comment on or make changes to this bug.