GCC 4.6 build warning: "jsemit.cpp:4112:10: warning: variable ‘forInLet’ set but not used [-Wunused-but-set-variable]"

RESOLVED FIXED in mozilla8

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks: 1 bug)

Trunk
mozilla8
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(1 attachment)

GCC 4.6 build warning:
{
jsemit.cpp:4112:10: warning: variable ‘forInLet’ set but not used [-Wunused-but-set-variable]
}

Looks like bug 381843 ( http://hg.mozilla.org/mozilla-central/rev/d8b2189bb4ba ) removed the last usages of this variable, & the variable itself can just go away.
Created attachment 545290 [details] [diff] [review]
fix
Attachment #545290 - Flags: review?(brendan)
Comment on attachment 545290 [details] [diff] [review]
fix

Yoink.
Attachment #545290 - Flags: review?(brendan) → review+
I landed this on tracemonkey...
   http://hg.mozilla.org/tracemonkey/rev/ab57a16c66fc
...but Waldo told me that JS team is currently landing patches on mozilla-inbound instead of on tracemonkey, and that I should re-land there instead.

I'll do that in the next day or so, once mozilla-inbound is less orange. :)
Re-landed on mozilla-inbound, per comment 3:
 http://hg.mozilla.org/integration/mozilla-inbound/rev/a5a4c874ace4

(At Waldo's direction, I'm ignoring the already-landed tracemonkey cset - not backing out there -- since that branch isn't being actively merged to m-c right now.)
Whiteboard: [build_warning] → [build_warning][inbound]
Merged:
http://hg.mozilla.org/mozilla-central/rev/a5a4c874ace4
Assignee: general → dholbert
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
OS: Linux → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Whiteboard: [build_warning][inbound] → [build_warning]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.