670794 - GCC 4.6 build warning: "jsemit.cpp:4112:10: warning: variable ‘forInLet’ set but not used [-Wunused-but-set-variable]"

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Daniel Holbert [:dholbert]]

GCC 4.6 build warning:
{
jsemit.cpp:4112:10: warning: variable ‘forInLet’ set but not used [-Wunused-but-set-variable]
}

Looks like bug 381843 ( http://hg.mozilla.org/mozilla-central/rev/d8b2189bb4ba ) removed the last usages of this variable, & the variable itself can just go away.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 545290 [details] [diff] [review]
fix

Yoink.

Comment 3

[Daniel Holbert [:dholbert]]

I landed this on tracemonkey...
   http://hg.mozilla.org/tracemonkey/rev/ab57a16c66fc
...but Waldo told me that JS team is currently landing patches on mozilla-inbound instead of on tracemonkey, and that I should re-land there instead.

I'll do that in the next day or so, once mozilla-inbound is less orange. :)

Comment 4

[Daniel Holbert [:dholbert]]

Re-landed on mozilla-inbound, per comment 3:
 http://hg.mozilla.org/integration/mozilla-inbound/rev/a5a4c874ace4

(At Waldo's direction, I'm ignoring the already-landed tracemonkey cset - not backing out there -- since that branch isn't being actively merged to m-c right now.)

Comment 5

[Mounir Lamouri (:mounir)]

Merged:
http://hg.mozilla.org/mozilla-central/rev/a5a4c874ace4