Closed
Bug 670830
Opened 13 years ago
Closed 10 years ago
click() should not be called on menuitem elements
Categories
(Testing Graveyard :: Mozmill, defect)
Testing Graveyard
Mozmill
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: rain1, Unassigned)
References
Details
Attachments
(1 file)
5.79 KB,
patch
|
Details | Diff | Splinter Review |
See bug 670829 for the reason why. This means that checkbox menuitems are currently completely broken with MozMill. One way to fix this might be to just remove the code that specializes in menu items and synthesize a mouse event, but I don't know if that'd work on Mac.
Comment 1•13 years ago
|
||
Sid, so what type of mouse event we would have to synthesize?
Reporter | ||
Comment 2•13 years ago
|
||
Just a regular click should suffice.
Comment 3•13 years ago
|
||
We cannot perform a regular click at least not on OS X where we do not have access to the native menubar.
Reporter | ||
Comment 4•13 years ago
|
||
Enn, any ideas for what we could do here? I guess our only option might be to set checked, then call click().
Comment 5•13 years ago
|
||
Are you trying to simulate a real mouse click? The click() method doesn't do that. The closest you can get are the methods in nsIDOMWindowUtils.
Reporter | ||
Comment 6•13 years ago
|
||
Yeah, but whimboo pointed out those won't work on Mac with its native menubar.
Comment 7•13 years ago
|
||
You can test activating native-mac menuitems with activateNativeMenuItemAt.
Comment 8•13 years ago
|
||
I don't think we need to worry about the Mac native menubar (though it'd be nice). The Mozmill tests for Thunderbird that are affected by this use context menus.
Reporter | ||
Comment 9•13 years ago
|
||
We have to worry about it in MozMill. (In reply to comment #7) > You can test activating native-mac menuitems with activateNativeMenuItemAt. Excellent, that looks like it'll work.
Reporter | ||
Comment 10•13 years ago
|
||
This is a good starting point I guess. However we need to work out how much to break the API. Currently click() doesn't close the menu item (even though I think it should), and it doesn't seem like select() is meant to be used for menubar menus (even though I think we should have a method to do just that).
Comment 11•13 years ago
|
||
Sid, sorry that we forgot about this bug. Meanwhile we do not want to ship further releases for 1.5 anymore, except it is really necessary. Would you mind to adapt this patch to the master branch of the mozmill repository so we could have it included in Mozmill 2? That would be great.
Reporter | ||
Comment 12•13 years ago
|
||
I think I can do that later.
Comment 13•10 years ago
|
||
Mozmill will reach its end of life soon. We are currently working on getting all the tests for Firefox ported to Marionette. For status updates please see bug 1080766.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
Assignee | ||
Updated•8 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•