Closed
Bug 670831
Opened 13 years ago
Closed 13 years ago
enable the chrome and mochitest-chrome uncaught exception sanity tests
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla11
People
(Reporter: heycam, Assigned: heycam)
References
Details
Attachments
(1 file)
|
4.49 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
Introduced disabled in bug 670817.
|
Assignee | |
Updated•13 years ago
|
|
|
Assignee | |
Comment 1•13 years ago
|
||
Changed the exact string thrown to avoid repetition of "uncaught exception" that appears in the logs.
Attachment #575130 -
Flags: review?(jmaher)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 575130 [details] [diff] [review] Enable some mochitest sanity tests for uncaught exception handling. Review of attachment 575130 [details] [diff] [review]: ----------------------------------------------------------------- Can we change 'hello' to be 'we did not catch what we expected'. Although this is a test, when debugging it for failures it could be confusing.
Attachment #575130 -
Flags: review?(jmaher) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
The actual output line with this patch is: TEST-INFO | chrome://mochitests/content/browser/testing/mochitest/tests/browser/browser_sanityException2.js | Console message: [JavaScript Error: "uncaught exception: hello"] Maybe a better string would be "this is a deliberately thrown exception" then.
|
|
Assignee | |
Comment 4•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b4e1c66eab6
|
||
Comment 5•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8b4e1c66eab6
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in
before you can comment on or make changes to this bug.
Description
•