670874 - Tests all attributes in test_textarea_attributes_reflection.html

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 545340 [details] [diff] [review]
Patch v1

--- a/content/html/content/test/reflect.js
+++ b/content/html/content/test/reflect.js
+  // TODO: remove this ugly hack when null stringification will work as expected.
+  if (element.tagName == "TEXTAREA" && idlAttr == "wrap") {

I'd prefer an extra parameter, so we can fix the attributes one by one.

Comment 2

[Mounir Lamouri (:mounir)]

(In reply to comment #1)
> Comment on attachment 545340 [details] [diff] [review] [review]
> Patch v1
> 
> --- a/content/html/content/test/reflect.js
> +++ b/content/html/content/test/reflect.js
> +  // TODO: remove this ugly hack when null stringification will work as
> expected.
> +  if (element.tagName == "TEXTAREA" && idlAttr == "wrap") {
> 
> I'd prefer an extra parameter, so we can fix the attributes one by one.

If it happens that we actually fix the attributes one by one, adding a parameter would be useful. For the moment, I don't think we need it.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

OK. When you reland it, I'd slightly prefer testing localName rather than tagName, though.

Comment 4

[Marco Bonardo [:mak]]

this has been backed out by ehsan due to bustage with all the other changesets in the same push

Comment 5

[:ehsan akhgari]

http://hg.mozilla.org/mozilla-central/rev/780471850bcf