Closed Bug 670874 Opened 11 years ago Closed 11 years ago

Tests all attributes in test_textarea_attributes_reflection.html

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: mounir, Assigned: mounir)

Details

Attachments

(1 file)

Attached patch Patch v1Splinter Review
No description provided.
Attachment #545340 - Flags: review?(Ms2ger)
Comment on attachment 545340 [details] [diff] [review]
Patch v1

--- a/content/html/content/test/reflect.js
+++ b/content/html/content/test/reflect.js
+  // TODO: remove this ugly hack when null stringification will work as expected.
+  if (element.tagName == "TEXTAREA" && idlAttr == "wrap") {

I'd prefer an extra parameter, so we can fix the attributes one by one.
Attachment #545340 - Flags: review?(Ms2ger) → review+
(In reply to comment #1)
> Comment on attachment 545340 [details] [diff] [review] [review]
> Patch v1
> 
> --- a/content/html/content/test/reflect.js
> +++ b/content/html/content/test/reflect.js
> +  // TODO: remove this ugly hack when null stringification will work as
> expected.
> +  if (element.tagName == "TEXTAREA" && idlAttr == "wrap") {
> 
> I'd prefer an extra parameter, so we can fix the attributes one by one.

If it happens that we actually fix the attributes one by one, adding a parameter would be useful. For the moment, I don't think we need it.
Flags: in-testsuite+
Whiteboard: [needs review] → [inbound]
OK. When you reland it, I'd slightly prefer testing localName rather than tagName, though.
this has been backed out by ehsan due to bustage with all the other changesets in the same push
Whiteboard: [inbound]
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/780471850bcf
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.