Closed
Bug 670874
Opened 10 years ago
Closed 10 years ago
Tests all attributes in test_textarea_attributes_reflection.html
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: mounir, Assigned: mounir)
Details
Attachments
(1 file)
13.36 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #545340 -
Flags: review?(Ms2ger)
Comment 1•10 years ago
|
||
Comment on attachment 545340 [details] [diff] [review] Patch v1 --- a/content/html/content/test/reflect.js +++ b/content/html/content/test/reflect.js + // TODO: remove this ugly hack when null stringification will work as expected. + if (element.tagName == "TEXTAREA" && idlAttr == "wrap") { I'd prefer an extra parameter, so we can fix the attributes one by one.
Attachment #545340 -
Flags: review?(Ms2ger) → review+
Assignee | ||
Comment 2•10 years ago
|
||
(In reply to comment #1) > Comment on attachment 545340 [details] [diff] [review] [review] > Patch v1 > > --- a/content/html/content/test/reflect.js > +++ b/content/html/content/test/reflect.js > + // TODO: remove this ugly hack when null stringification will work as > expected. > + if (element.tagName == "TEXTAREA" && idlAttr == "wrap") { > > I'd prefer an extra parameter, so we can fix the attributes one by one. If it happens that we actually fix the attributes one by one, adding a parameter would be useful. For the moment, I don't think we need it.
Assignee | ||
Updated•10 years ago
|
Flags: in-testsuite+
Whiteboard: [needs review] → [inbound]
Comment 3•10 years ago
|
||
OK. When you reland it, I'd slightly prefer testing localName rather than tagName, though.
Comment 4•10 years ago
|
||
this has been backed out by ehsan due to bustage with all the other changesets in the same push
Whiteboard: [inbound]
Assignee | ||
Updated•10 years ago
|
Whiteboard: [inbound]
Comment 5•10 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/780471850bcf
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•