The default bug view has changed. See this FAQ.

Tests all attributes in test_textarea_attributes_reflection.html

RESOLVED FIXED in mozilla8

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
mozilla8
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 545340 [details] [diff] [review]
Patch v1
Attachment #545340 - Flags: review?(Ms2ger)
Comment on attachment 545340 [details] [diff] [review]
Patch v1

--- a/content/html/content/test/reflect.js
+++ b/content/html/content/test/reflect.js
+  // TODO: remove this ugly hack when null stringification will work as expected.
+  if (element.tagName == "TEXTAREA" && idlAttr == "wrap") {

I'd prefer an extra parameter, so we can fix the attributes one by one.
Attachment #545340 - Flags: review?(Ms2ger) → review+
(Assignee)

Comment 2

6 years ago
(In reply to comment #1)
> Comment on attachment 545340 [details] [diff] [review] [review]
> Patch v1
> 
> --- a/content/html/content/test/reflect.js
> +++ b/content/html/content/test/reflect.js
> +  // TODO: remove this ugly hack when null stringification will work as
> expected.
> +  if (element.tagName == "TEXTAREA" && idlAttr == "wrap") {
> 
> I'd prefer an extra parameter, so we can fix the attributes one by one.

If it happens that we actually fix the attributes one by one, adding a parameter would be useful. For the moment, I don't think we need it.
(Assignee)

Updated

6 years ago
Flags: in-testsuite+
Whiteboard: [needs review] → [inbound]
OK. When you reland it, I'd slightly prefer testing localName rather than tagName, though.
this has been backed out by ehsan due to bustage with all the other changesets in the same push
Whiteboard: [inbound]
(Assignee)

Updated

6 years ago
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/780471850bcf
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.