Closed Bug 670880 Opened 13 years ago Closed 13 years ago

Spatial navigation tests call waitForExplicitFinish() after finish()

Categories

(Toolkit Graveyard :: Spatial Navigation, defect)

Product:
Toolkit Graveyard
Component:
Spatial Navigation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla8

People

(Reporter: darktrojan, Assigned: dougt)

References

Details

Attachments

(1 file, 1 obsolete file)

patch v.2
49.44 KB, patch
blassey
: review+
Details | Diff | Splinter Review 
AFAICT, these tests haven't run since SpatialNavUtils.js was created in 2008!
Attached patch patch (obsolete) — — Splinter Review 

  

  



        Attachment #545344 -
        Flags: review?(doug.turner)

    
    

    
  
how about just removing Spatial navigation from mozilla-central?

  

  



    
  
Assignee: geoff → doug.turner

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch v.2
        — 
          — Splinter Review
      

    


  
http://tbpl.mozilla.org/?tree=Try&rev=b216c64a375b

  

  



        Attachment #545344 -
        Attachment is obsolete: true

        Attachment #546796 -
        Flags: review?(blassey.bugs)

        Attachment #545344 -
        Flags: review?(doug.turner)

    
    

    
  
I vote for this!

  

  



        Attachment #546796 -
        Flags: review?(blassey.bugs) → review+

    
    

    
  
Time to clean the house :) 

The followings bugs can be closed as WONTFIX after landing this patch:

bug 448174
bug 464598
bug 459008
bug 463516
bug 305657
bug 452274
bug 492409
bug 395704

  

  



    
    

    
  
what is the eta for landing this patch?

  

  



    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/f46c32f62931

  

  


Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8

    
    

    
  
The removed-files.in change here wasn't quite right (should have moved out of the MOZ_OMNIJAR test rather getting removed). Fixing that up in bug 705974.

  

  


Blocks: 705974

    
  
Product: Toolkit → Toolkit Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: