Make nsGenericDOMDataNode and nsTextFragment participate to the DOM Memory Reporter

RESOLVED FIXED in mozilla8

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
mozilla8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 545397 [details] [diff] [review]
Patch v1
Attachment #545397 - Flags: review?(jst)
Comment on attachment 545397 [details] [diff] [review]
Patch v1

- In nsTextFragment::SizeOf():

+    PRInt64 size = sizeof(*this);
+    size += GetLength() * Is2b() ? sizeof(*m2b) : sizeof(*m1b);

We should only add the size of the text itself if mState.mInHeap is true, if not, it's a text fragment that points to a shared static whitespace string.

r=jst with that.
Attachment #545397 - Flags: review?(jst) → review+
(Assignee)

Updated

6 years ago
Whiteboard: [needs review] → [inbound]
this has been backed out by ehsan due to bustage with all the other changesets in the same push
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/0ea1783b5f6e
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.