The default bug view has changed. See this FAQ.

Create nsLocation.h to declare nsLocation instead of doing that in nsGlobalWindow.h

RESOLVED FIXED in mozilla8

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
mozilla8
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

6 years ago
Created attachment 545415 [details] [diff] [review]
Patch v1
Attachment #545415 - Flags: review?(jst)
Um, did you forget to hg add nsLocation.h? :)
(Assignee)

Comment 2

6 years ago
Created attachment 545634 [details] [diff] [review]
Patch v1.1

Oups :)
Attachment #545415 - Attachment is obsolete: true
Attachment #545634 - Flags: review?(jst)
Attachment #545415 - Flags: review?(jst)
(Assignee)

Comment 3

6 years ago
Created attachment 545637 [details] [diff] [review]
Patch v1.2

Without SizeOf() declaration, it might be even better...
Attachment #545634 - Attachment is obsolete: true
Attachment #545637 - Flags: review?(jst)
Attachment #545634 - Flags: review?(jst)
I've wanted to do that for quite a while... Thanks!

Updated

6 years ago
Attachment #545637 - Flags: review?(jst) → review+
(Assignee)

Updated

6 years ago
Flags: in-testsuite-
Whiteboard: [needs review] → [inbound]
this has been backed out by ehsan due to bustage with all the other changesets in the same push
Whiteboard: [inbound]
(Assignee)

Comment 6

6 years ago
Created attachment 548304 [details] [diff] [review]
Patch v1.3

Trying to figure out why this is failing to build on Windows...
Attachment #545637 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/b53395484bdf
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.