Closed Bug 670986 Opened 9 years ago Closed 9 years ago

Create nsLocation.h to declare nsLocation instead of doing that in nsGlobalWindow.h

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: mounir, Assigned: mounir)

Details

(Whiteboard: [inbound])

Attachments

(1 file, 3 obsolete files)

Attached patch Patch v1 (obsolete) — Splinter Review
No description provided.
Attachment #545415 - Flags: review?(jst)
Um, did you forget to hg add nsLocation.h? :)
Attached patch Patch v1.1 (obsolete) — Splinter Review
Oups :)
Attachment #545415 - Attachment is obsolete: true
Attachment #545634 - Flags: review?(jst)
Attachment #545415 - Flags: review?(jst)
Attached patch Patch v1.2 (obsolete) — Splinter Review
Without SizeOf() declaration, it might be even better...
Attachment #545634 - Attachment is obsolete: true
Attachment #545637 - Flags: review?(jst)
Attachment #545634 - Flags: review?(jst)
I've wanted to do that for quite a while... Thanks!
Attachment #545637 - Flags: review?(jst) → review+
Flags: in-testsuite-
Whiteboard: [needs review] → [inbound]
this has been backed out by ehsan due to bustage with all the other changesets in the same push
Whiteboard: [inbound]
Attached patch Patch v1.3Splinter Review
Trying to figure out why this is failing to build on Windows...
Attachment #545637 - Attachment is obsolete: true
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/b53395484bdf
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.