670994 - nsHttpPipeline::ResumeSend() in not unreachable

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Patrick McManus [:mcmanus]]

This is patch is originally from 599164 and is broken out at the reviewer's request:

"" @@ +215,5 @@
>  nsresult
>  nsHttpPipeline::ResumeSend()
>  {
> +    if (mConnection)
> +        return mConnection->ResumeSend();

This might get called from nsHttpTransaction::OnInputStreamReady when transaction's request buffer was not filled with all data to send and later those data was pushed to that buffer (we resume sending the rest of the request data).  This is an important fix and should be in a separate bug bellow in the patch queue.  Even before the "bursty" patch gets landed.""

Comment 1

[Patrick McManus [:mcmanus]]

Attachment: patch v1

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 545423 [details] [diff] [review]
patch v1

Review of attachment 545423 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab

Comment 3

[Patrick McManus [:mcmanus]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c9b326ff4c16

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c9b326ff4c16