Closed Bug 670994 Opened 13 years ago Closed 12 years ago

nsHttpPipeline::ResumeSend() in not unreachable

Categories

(Core :: Networking: HTTP, defect)

Product:
Core
Component:
Networking: HTTP
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla11

People

(Reporter: mcmanus, Assigned: mcmanus)

References

Details

Attachments

(1 file)

patch v1
973 bytes, patch
mayhemer
: review+
Details | Diff | Splinter Review 
This is patch is originally from 599164 and is broken out at the reviewer's request:

"" @@ +215,5 @@
>  nsresult
>  nsHttpPipeline::ResumeSend()
>  {
> +    if (mConnection)
> +        return mConnection->ResumeSend();

This might get called from nsHttpTransaction::OnInputStreamReady when transaction's request buffer was not filled with all data to send and later those data was pushed to that buffer (we resume sending the rest of the request data).  This is an important fix and should be in a separate bug bellow in the patch queue.  Even before the "bursty" patch gets landed.""
Blocks: 599164
Summary: nsHttpPipeline::ResumeSend() → nsHttpPipeline::ResumeSend() in not unreachable
Attached patch patch v1 — — Splinter Review 
Assignee: nobody → mcmanus
Status: NEW → ASSIGNED

        Attachment #545423 -
        Flags: review?(honzab.moz)

    
    

    
  
Comment on attachment 545423 [details] [diff] [review]
patch v1

Review of attachment 545423 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab

        Attachment #545423 -
        Flags: review?(honzab.moz) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/c9b326ff4c16
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.