The default bug view has changed. See this FAQ.

nsHttpPipeline::ResumeSend() in not unreachable

RESOLVED FIXED in mozilla11

Status

()

Core
Networking: HTTP
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: mcmanus, Assigned: mcmanus)

Tracking

unspecified
mozilla11
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
This is patch is originally from 599164 and is broken out at the reviewer's request:

"" @@ +215,5 @@
>  nsresult
>  nsHttpPipeline::ResumeSend()
>  {
> +    if (mConnection)
> +        return mConnection->ResumeSend();

This might get called from nsHttpTransaction::OnInputStreamReady when transaction's request buffer was not filled with all data to send and later those data was pushed to that buffer (we resume sending the rest of the request data).  This is an important fix and should be in a separate bug bellow in the patch queue.  Even before the "bursty" patch gets landed.""
(Assignee)

Updated

6 years ago
Blocks: 599164
Summary: nsHttpPipeline::ResumeSend() → nsHttpPipeline::ResumeSend() in not unreachable
(Assignee)

Comment 1

6 years ago
Created attachment 545423 [details] [diff] [review]
patch v1
Assignee: nobody → mcmanus
Status: NEW → ASSIGNED
Attachment #545423 - Flags: review?(honzab.moz)
Comment on attachment 545423 [details] [diff] [review]
patch v1

Review of attachment 545423 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab
Attachment #545423 - Flags: review?(honzab.moz) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9b326ff4c16
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/c9b326ff4c16
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.