671062 - The up and down arrows used to adjust the number (minutes, hours, days) for the snooze are missing

Status: RESOLVED FIXED

(Calendar :: Alarms, defect)

Description

[dkmail]

Attachment: screen.jpg

User Agent: Mozilla/5.0 (Windows NT 6.0) AppleWebKit/534.30 (KHTML, like Gecko) Chrome/12.0.742.112 Safari/534.30

Steps to reproduce:

I was trying to change the amount of time on the snooze menu of an alarm.


Actual results:

The up and down arrows used to adjust the number (minutes, hours, days) for the snooze were missing.


Expected results:

The arrows should be there.

Comment 1

[Decathlon]

Attachment: [after beta] patch - v1

This patch works but maybe there are other better ways to fix it.
I apologize if it's a silly question, but could you explain me why adding the stylesheet as a resource inside the binding id="calendar-snooze-popup", doesn't work?

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 545686 [details] [diff] [review]
[after beta] patch - v1

I wonder why we were hiding the spin buttons. Maybe they caused some events to fire that close the popup. I'd like to do this one after 1.0b5 too, the snooze popup is very fragile and I don't want to break anything.

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 545686 [details] [diff] [review]
[after beta] patch - v1

Works good.
r+

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/f4bbdf829ffd>

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to comm-aurora <http://hg.mozilla.org/releases/comm-aurora/rev/81675a52450a>

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to comm-beta <http://hg.mozilla.org/releases/comm-beta/rev/ef76798bd7c8>