Closed Bug 671069 Opened 13 years ago Closed 12 years ago

signed/unsigned warnings in pk11wrap

Categories

(NSS :: Libraries, defect)

All
Windows 7
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
3.13.4

People

(Reporter: briansmith, Assigned: briansmith)

Details

Attachments

(1 file)

Simple patch forthcoming.
Assignee: nobody → bsmith
Attachment #545470 - Flags: review?(rrelyea)
Comment on attachment 545470 [details] [diff] [review]
change types of index variables to prevent warnings

r+ 

It's tricker than it looks, but making i unsigned is safe since we can prove that I can't go negative.

bob
Attachment #545470 - Flags: review?(rrelyea) → review+
Keywords: checkin-needed
Checking in pk11merge.c;
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11merge.c,v  <--  pk11merge.c
new revision: 1.9; previous revision: 1.8
done
Checking in pk11sdr.c;
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11sdr.c,v  <--  pk11sdr.c
new revision: 1.23; previous revision: 1.22
done
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.13.4
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: