Closed
Bug 671080
Opened 13 years ago
Closed 13 years ago
Add assertion checking to ensure no unintentional cross-compartment wrappers are created
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: billm, Assigned: billm)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.64 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
Bug 670702 has evidence that some non-cross compartment JSWrappers have pointers outside their compartment. Blake confirms that this is not expected. This patch adds some additional opt-mode assertions to try and narrow down the code creating these pointers. I'm sorry about how gross the check is. Unfortunately, we're not allowed to get the compartment for static strings, since they're not part of the GC heap.
Attachment #545480 -
Flags: review?(mrbkap)
|
Assignee | |
Comment 1•13 years ago
|
||
Since the priv field can't be a string, this patch is shorter.
Assignee: general → wmccloskey
Attachment #545480 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #545485 -
Flags: review?(mrbkap)
Attachment #545480 -
Flags: review?(mrbkap)
|
||
Updated•13 years ago
|
Attachment #545485 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [inbound]
|
||
Comment 2•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/4fc08ab607db
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•