67122 - PR_CALLBACK should be placed after the return type.

Status: VERIFIED FIXED

(NSS :: Libraries, defect, P1)

Description

[Wan-Teh Chang]

The correct position for PR_CALLBACK is after the return
type in a function prototype.  In some NSS files, PR_CALLBACK
is incorrectly placed before the function return type.  This
breaks compilation on OS/2, where PR_CALLBACK is not an empty
macro.

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch.

Comment 2

[Wan-Teh Chang]

Please review the proposed patch.

Comment 3

[Robert Relyea]

OK, patch looks good.

I think this was the only real issue I had with the OS/2 changes was whether
moving PR_CALLBACK would break other platforms.

Comment 4

[Mike Kaply [:mkaply]]

FYI, as far as the other platform thing goes, it was in a different place for 
Win16.

Check out: http://bugzilla.mozilla.org/show_bug.cgi?id=33610

It has a really good synopsis of the whole thing.

The proper way to do this is to use PR_CALLBACK_PTR so we can locate the calling 
convention in different places, but it was decided that since Win16 is not 
supported and OS/2 is the only one that uses calling convention, we shouldn't 
worry about it.

Comment 5

[Wan-Teh Chang]

I remember that one.  Now I understand why we had to move
the position of PR_CALLBACK in function declarations in
NSPR.

Like Mike said, since we do not support Win16 now, and since
NSPR has already been converted this way, I think this patch
is fine for NSS too.  I've checked it in on the tip and the
NSS_3_1_BRANCH.

Comment 6

[Mike Kaply [:mkaply]]

Verify fixed