671258 - Wrong site preferences listed in the site identity container in the pageaction-reset entry

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Mozilla/5.0 (Android; Linux armv7; rv:8.0a1) Gecko/20110713 Firefox/8.0a1 Fennec/8.0a1
Device: Samsung Nexus S
Android: 2.3.4

The pageaction-reset entry in the site-identity panel for site specific preferences and permissions are listing unselected preferences in the description text.

STR:
1. http://www.google.com
2. Install As App -> Select "Desktop Notifications".
3. Open the site-identity panel

ER: "Clear Site Preferences" with a description text, "Desktop Notifications"
AR: "Clear Site Preferences" with a description text, "Offline Storage, Web Notifications"

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

We should change the code in the dialog a bit:
* If permission is not set before the dialog is shown and the checkbox is not checked on OK - do not touch the permission.
* If permission is set before the dialog is shown and the checkbox is not checked on OK - remove the permission.
* If permission is not set before the dialog is shown and the checkbox is checked on OK - set the permission.
* If permission is set before the dialog is shown and the checkbox is checked on OK - do not touch the permission.

Fabrice, does this make sense?

Comment 2

[[:fabrice] Fabrice Desré]

Attachment: patch

Implement the fix by only updating permissions that have changed. Also corrected a typo in "desktop-notification"

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 546183 [details] [diff] [review]
patch

nice

Comment 4

[[:fabrice] Fabrice Desré]

pushed to inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/f46a5cffdb66

Comment 5

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/f46a5cffdb66

Comment 6

[Cristian Nicolae (:xti)]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:8.0a1)Gecko/20110901
Firefox/8.0a1 Fennec/8.0a1
Device: Samsung Galaxy S
OS: Android 2.2

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Filed bug 684244 for the string change